bloc for holidays

Reviewed-on: #68
Reviewed-by: Pupsi <larslukasneuhaus@gmx.de>

analysis_options.yaml

@@ -9,6 +9,10 @@
 # packages, and plugins designed to encourage good coding practices.
 include: package:flutter_lints/flutter.yaml
 
+analyzer:
+  errors:
+    invalid_annotation_target: ignore
+
 linter:
   # The lint rules applied to this project can be customized in the
   # section below to disable rules from the `package:flutter_lints/flutter.yaml`
@@ -28,6 +32,13 @@ linter:
     prefer_relative_imports: true
     unnecessary_lambdas: true
     prefer_single_quotes: true
+    prefer_if_elements_to_conditional_expressions: true
+    prefer_expression_function_bodies: true
+    omit_local_variable_types: true
+    eol_at_end_of_file: true
+    cast_nullable_to_non_nullable: true
+    avoid_void_async: true
+    avoid_multiple_declarations_per_line: true
 
 # Additional information about this file can be found at
 # https://dart.dev/guides/language/analysis-options

android/app/build.gradle

@@ -45,7 +45,7 @@ android {
         applicationId "eu.mhsl.marianum.mobile.client"
         // You can update the following values to match your application needs.
         // For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-gradle-build-configuration.
-        minSdkVersion 19
+        minSdkVersion 21
         targetSdkVersion flutter.targetSdkVersion
         versionCode flutterVersionCode.toInteger()
         versionName flutterVersionName

android/settings.gradle

@@ -20,7 +20,7 @@ pluginManagement {
 plugins {
     id "dev.flutter.flutter-plugin-loader" version "1.0.0"
     id "com.android.application" version "7.3.0" apply false
-    id "org.jetbrains.kotlin.android" version "1.7.10" apply false
+    id "org.jetbrains.kotlin.android" version "1.8.10" apply false
 }
 
 include ":app"

build.yaml

@@ -0,0 +1,7 @@
+targets:
+  $default:
+    builders:
+      json_serializable:
+        options:
+          explicit_to_json: false
+          generic_argument_factories: true

lib/api/apiError.dart

@@ -4,7 +4,5 @@ class ApiError {
   ApiError(this.message);
 
   @override
-  String toString() {
+  String toString() => 'ApiError: $message';
-    return 'ApiError: $message';
+}
-  }
-}

lib/api/apiParams.dart

@@ -1,3 +1,3 @@
 class ApiParams {
 
-}
+}

lib/api/apiRequest.dart

@@ -2,4 +2,4 @@
 
 class ApiRequest {
 
-}
+}

lib/api/apiResponse.dart

@@ -6,4 +6,4 @@ abstract class ApiResponse {
 
   @JsonKey(includeIfNull: false)
   late Map<String, String>? headers;
-}
+}

lib/api/holidays/getHolidays.dart

@@ -1,18 +1,16 @@
 import 'dart:convert';
-
 import 'package:http/http.dart' as http;
 
 import 'getHolidaysResponse.dart';
 
 class GetHolidays {
   Future<GetHolidaysResponse> query() async {
-    String response = (await http.get(Uri.parse('https://ferien-api.de/api/v1/holidays/HE'))).body;
+    var response = (await http.get(Uri.parse('https://ferien-api.de/api/v1/holidays/HE'))).body;
+    var data = jsonDecode(response) as List<dynamic>;
     return GetHolidaysResponse(
         List<GetHolidaysResponseObject>.from(
-            jsonDecode(response).map<GetHolidaysResponseObject>(
+            data.map<GetHolidaysResponseObject>((e) => GetHolidaysResponseObject.fromJson(e as Map<String, dynamic>))
-                    GetHolidaysResponseObject.fromJson
-            )
         )
     );
   }
-}
+}

lib/api/holidays/getHolidaysCache.dart

@@ -6,24 +6,21 @@ import 'getHolidaysResponse.dart';
 
 class GetHolidaysCache extends RequestCache<GetHolidaysResponse> {
   GetHolidaysCache({onUpdate, renew}) : super(RequestCache.cacheDay, onUpdate, renew: renew) {
-    start('MarianumMobile', 'state-holidays');
+    start('state-holidays');
   }
 
   @override
   GetHolidaysResponse onLocalData(String json) {
     List<dynamic> parsedListJson = jsonDecode(json)['data'];
     return GetHolidaysResponse(
-        List<GetHolidaysResponseObject>.from(
+      List<GetHolidaysResponseObject>.from(
-            parsedListJson.map<GetHolidaysResponseObject>(
+        parsedListJson.map<GetHolidaysResponseObject>(
-                    // ignore: unnecessary_lambdas
+          (i) => GetHolidaysResponseObject.fromJson(i as Map<String, dynamic>)
-                    (dynamic i) => GetHolidaysResponseObject.fromJson(i)
-            )
         )
+      )
     );
   }
 
   @override
-  Future<GetHolidaysResponse> onLoad() {
+  Future<GetHolidaysResponse> onLoad() => GetHolidays().query();
-    return GetHolidays().query();
+}
-  }
-}

lib/api/holidays/getHolidaysResponse.dart

@@ -35,4 +35,4 @@ class GetHolidaysResponseObject {
 
   factory GetHolidaysResponseObject.fromJson(Map<String, dynamic> json) => _$GetHolidaysResponseObjectFromJson(json);
   Map<String, dynamic> toJson() => _$GetHolidaysResponseObjectToJson(this);
-}
+}

lib/api/marianumcloud/autocomplete/autocompleteApi.dart

@@ -2,7 +2,6 @@ import 'dart:convert';
 import 'dart:io';
 
 import 'package:http/http.dart' as http;
-import 'package:http/http.dart';
 
 import '../../../model/accountData.dart';
 import '../../../model/endpointData.dart';
@@ -10,7 +9,7 @@ import 'autocompleteResponse.dart';
 
 class AutocompleteApi {
   Future<AutocompleteResponse> find(String query) async {
-    Map<String, dynamic> getParameters = {
+    var getParameters = <String, dynamic>{
       'search': query,
       'itemType': ' ',
       'itemId': ' ',
@@ -18,16 +17,16 @@ class AutocompleteApi {
       'limit': '10',
     };
 
-    Map<String, String> headers = {};
+    var headers = <String, String>{};
     headers.putIfAbsent('Accept', () => 'application/json');
     headers.putIfAbsent('OCS-APIRequest', () => 'true');
 
-    Uri endpoint = Uri.https('${AccountData().buildHttpAuthString()}@${EndpointData().nextcloud().domain}', '${EndpointData().nextcloud().path}/ocs/v2.php/core/autocomplete/get', getParameters);
+    var endpoint = Uri.https('${AccountData().buildHttpAuthString()}@${EndpointData().nextcloud().domain}', '${EndpointData().nextcloud().path}/ocs/v2.php/core/autocomplete/get', getParameters);
 
-    Response response = await http.get(endpoint, headers: headers);
+    var response = await http.get(endpoint, headers: headers);
     if(response.statusCode != HttpStatus.ok) throw Exception('Api call failed with ${response.statusCode}: ${response.body}');
-    String result = response.body;
+    var result = response.body;
     return AutocompleteResponse.fromJson(jsonDecode(result)['ocs']);
   }
 
-}
+}

lib/api/marianumcloud/autocomplete/autocompleteResponse.dart

@@ -27,4 +27,4 @@ class AutocompleteResponseObject {
 
   factory AutocompleteResponseObject.fromJson(Map<String, dynamic> json) => _$AutocompleteResponseObjectFromJson(json);
   Map<String, dynamic> toJson() => _$AutocompleteResponseObjectToJson(this);
-}
+}

lib/api/marianumcloud/files-sharing/fileSharingApi.dart

@@ -1,7 +1,6 @@
 import 'dart:io';
 
 import 'package:http/http.dart' as http;
-import 'package:http/http.dart';
 
 import '../../../model/accountData.dart';
 import '../../../model/endpointData.dart';
@@ -9,15 +8,15 @@ import 'fileSharingApiParams.dart';
 
 class FileSharingApi {
   Future<void> share(FileSharingApiParams query) async {
-    Map<String, String> headers = {};
+    var headers = <String, String>{};
     headers.putIfAbsent('Accept', () => 'application/json');
     headers.putIfAbsent('OCS-APIRequest', () => 'true');
 
-    Uri endpoint = Uri.https('${AccountData().buildHttpAuthString()}@${EndpointData().nextcloud().domain}', '${EndpointData().nextcloud().path}/ocs/v2.php/apps/files_sharing/api/v1/shares', query.toJson().map((key, value) => MapEntry(key, value.toString())));
+    var endpoint = Uri.https('${AccountData().buildHttpAuthString()}@${EndpointData().nextcloud().domain}', '${EndpointData().nextcloud().path}/ocs/v2.php/apps/files_sharing/api/v1/shares', query.toJson().map((key, value) => MapEntry(key, value.toString())));
-    Response response = await http.post(endpoint, headers: headers);
+    var response = await http.post(endpoint, headers: headers);
 
     if(response.statusCode != HttpStatus.ok) {
       throw Exception('Api call failed with ${response.statusCode}: ${response.body}');
     }
   }
-}
+}

lib/api/marianumcloud/files-sharing/fileSharingApiParams.dart

@@ -20,4 +20,4 @@ class FileSharingApiParams {
 
   factory FileSharingApiParams.fromJson(Map<String, dynamic> json) => _$FileSharingApiParamsFromJson(json);
   Map<String, dynamic> toJson() => _$FileSharingApiParamsToJson(this);
-}
+}

lib/api/marianumcloud/talk/chat/getChat.dart

@@ -14,13 +14,9 @@ class GetChat extends TalkApi<GetChatResponse> {
   GetChat(this.chatToken, this.params) : super('v1/chat/$chatToken', null, getParameters: params.toJson());
 
   @override
-  assemble(String raw) {
+  assemble(String raw) => GetChatResponse.fromJson(jsonDecode(raw)['ocs']);
-    return GetChatResponse.fromJson(jsonDecode(raw)['ocs']);
-  }
 
   @override
-  Future<Response> request(Uri uri, Object? body, Map<String, String>? headers) {
+  Future<Response> request(Uri uri, Object? body, Map<String, String>? headers) => http.get(uri, headers: headers);
-    return http.get(uri, headers: headers);
-  }
   
-}
+}

lib/api/marianumcloud/talk/chat/getChatCache.dart

@@ -9,12 +9,11 @@ class GetChatCache extends RequestCache<GetChatResponse> {
   String chatToken;
 
   GetChatCache({required onUpdate, required this.chatToken}) : super(RequestCache.cacheNothing, onUpdate) {
-    start('MarianumMobile', 'nc-chat-$chatToken');
+    start('nc-chat-$chatToken');
   }
 
   @override
-  Future<GetChatResponse> onLoad() {
+  Future<GetChatResponse> onLoad() => GetChat(
-    return GetChat(
       chatToken,
       GetChatParams(
         lookIntoFuture: GetChatParamsSwitch.off,
@@ -22,11 +21,8 @@ class GetChatCache extends RequestCache<GetChatResponse> {
         limit: 200,
       )
     ).run();
-  }
 
   @override
-  GetChatResponse onLocalData(String json) {
+  GetChatResponse onLocalData(String json) => GetChatResponse.fromJson(jsonDecode(json));
-    return GetChatResponse.fromJson(jsonDecode(json));
-  }
 
-}
+}

lib/api/marianumcloud/talk/chat/getChatParams.dart

@@ -31,4 +31,4 @@ class GetChatParams extends ApiParams {
 enum GetChatParamsSwitch {
   @JsonValue(1) on,
   @JsonValue(0) off,
-}
+}

lib/api/marianumcloud/talk/chat/getChatResponse.dart

@@ -16,7 +16,7 @@ class GetChatResponse extends ApiResponse {
   Map<String, dynamic> toJson() => _$GetChatResponseToJson(this);
 
   List<GetChatResponseObject> sortByTimestamp() {
-    List<GetChatResponseObject> sorted = data.toList();
+    var sorted = data.toList();
     sorted.sort((a, b) => a.timestamp.compareTo(b.timestamp));
     return sorted;
   }
@@ -38,6 +38,7 @@ class GetChatResponseObject {
   Map<String, int>? reactions;
   List<String>? reactionsSelf;
   @JsonKey(fromJson: _fromJson) Map<String, RichObjectString>? messageParameters;
+  GetChatResponseObject? parent;
 
   GetChatResponseObject(
       this.id,
@@ -53,19 +54,19 @@ class GetChatResponseObject {
       this.message,
       this.messageParameters,
       this.reactions,
-      this.reactionsSelf
+      this.reactionsSelf,
+      this.parent,
   );
 
   factory GetChatResponseObject.fromJson(Map<String, dynamic> json) => _$GetChatResponseObjectFromJson(json);
   Map<String, dynamic> toJson() => _$GetChatResponseObjectToJson(this);
 
   static GetChatResponseObject getDateDummy(int timestamp) {
-    DateTime elementDate = DateTime.fromMillisecondsSinceEpoch(timestamp * 1000);
+    var elementDate = DateTime.fromMillisecondsSinceEpoch(timestamp * 1000);
     return getTextDummy(Jiffy.parseFromDateTime(elementDate).format(pattern: 'dd.MM.yyyy'));
   }
 
-  static GetChatResponseObject getTextDummy(String text) {
+  static GetChatResponseObject getTextDummy(String text) => GetChatResponseObject(
-    return GetChatResponseObject(
         0,
         '',
         GetRoomResponseObjectMessageActorType.user,
@@ -79,15 +80,15 @@ class GetChatResponseObject {
         text,
         null,
         null,
-        null
+        null,
+        null,
     );
-  }
 
 }
 
 Map<String, RichObjectString>? _fromJson(json) {
   if(json is Map<String, dynamic>) {
-    Map<String, RichObjectString> data = {};
+    var data = <String, RichObjectString>{};
     for (var element in json.keys) {
       data.putIfAbsent(element, () => RichObjectString.fromJson(json[element]));
     }
@@ -119,4 +120,4 @@ enum RichObjectStringObjectType {
   @JsonValue('guest') guest,
   @JsonValue('highlight') highlight,
   @JsonValue('talk-poll') talkPoll,
-}
+}

lib/api/marianumcloud/talk/chat/getChatResponse.g.dart

@@ -52,6 +52,10 @@ GetChatResponseObject _$GetChatResponseObjectFromJson(
       (json['reactionsSelf'] as List<dynamic>?)
           ?.map((e) => e as String)
           .toList(),
+      json['parent'] == null
+          ? null
+          : GetChatResponseObject.fromJson(
+              json['parent'] as Map<String, dynamic>),
     );
 
 Map<String, dynamic> _$GetChatResponseObjectToJson(
@@ -74,6 +78,7 @@ Map<String, dynamic> _$GetChatResponseObjectToJson(
       'reactionsSelf': instance.reactionsSelf,
       'messageParameters':
           instance.messageParameters?.map((k, e) => MapEntry(k, e.toJson())),
+      'parent': instance.parent?.toJson(),
     };
 
 const _$GetRoomResponseObjectMessageActorTypeEnumMap = {

lib/api/marianumcloud/talk/chat/richObjectStringProcessor.dart

@@ -11,4 +11,4 @@ class RichObjectStringProcessor {
 
     return message;
   }
-}
+}

lib/api/marianumcloud/talk/createRoom/createRoom.dart

@@ -10,9 +10,7 @@ class CreateRoom extends TalkApi {
   CreateRoom(this.params) : super('v4/room', params);
 
   @override
-  assemble(String raw) {
+  assemble(String raw) => null;
-    return null;
-  }
 
   @override
   Future<Response>? request(Uri uri, Object? body, Map<String, String>? headers) {
@@ -22,4 +20,4 @@ class CreateRoom extends TalkApi {
 
     return null;
   }
-}
+}

lib/api/marianumcloud/talk/createRoom/createRoomParams.dart

@@ -24,4 +24,4 @@ class CreateRoomParams extends ApiParams {
 
   factory CreateRoomParams.fromJson(Map<String, dynamic> json) => _$CreateRoomParamsFromJson(json);
   Map<String, dynamic> toJson() => _$CreateRoomParamsToJson(this);
-}
+}

lib/api/marianumcloud/talk/deleteMessage/deleteMessage.dart

@@ -10,13 +10,9 @@ class DeleteMessage extends TalkApi {
   DeleteMessage(this.chatToken, this.messageId) : super('v1/chat/$chatToken/$messageId', null);
 
   @override
-  assemble(String raw) {
+  assemble(String raw) => null;
-    return null;
-  }
 
   @override
-  Future<Response>? request(Uri uri, ApiParams? body, Map<String, String>? headers) {
+  Future<Response>? request(Uri uri, ApiParams? body, Map<String, String>? headers) => http.delete(uri, headers: headers);
-    return http.delete(uri, headers: headers);
-  }
 
-}
+}

lib/api/marianumcloud/talk/deleteReactMessage/deleteReactMessage.dart

@@ -11,9 +11,7 @@ class DeleteReactMessage extends TalkApi {
   DeleteReactMessage({required this.chatToken, required this.messageId, required DeleteReactMessageParams params}) : super('v1/reaction/$chatToken/$messageId', params);
 
   @override
-  assemble(String raw) {
+  assemble(String raw) => null;
-    return null;
-  }
 
   @override
   Future<Response>? request(Uri uri, ApiParams? body, Map<String, String>? headers) {
@@ -23,4 +21,4 @@ class DeleteReactMessage extends TalkApi {
     return null;
   }
 
-}
+}

lib/api/marianumcloud/talk/deleteReactMessage/deleteReactMessageParams.dart

@@ -12,4 +12,4 @@ class DeleteReactMessageParams extends ApiParams {
 
   factory DeleteReactMessageParams.fromJson(Map<String, dynamic> json) => _$DeleteReactMessageParamsFromJson(json);
   Map<String, dynamic> toJson() => _$DeleteReactMessageParamsToJson(this);
-}
+}

lib/api/marianumcloud/talk/getParticipants/getParticipants.dart

@@ -10,13 +10,9 @@ class GetParticipants extends TalkApi<GetParticipantsResponse> {
   GetParticipants(this.token) : super('v4/room/$token/participants', null);
 
   @override
-  GetParticipantsResponse assemble(String raw) {
+  GetParticipantsResponse assemble(String raw) => GetParticipantsResponse.fromJson(jsonDecode(raw)['ocs']);
-    return GetParticipantsResponse.fromJson(jsonDecode(raw)['ocs']);
-  }
 
   @override
-  Future<http.Response> request(Uri uri, Object? body, Map<String, String>? headers) {
+  Future<http.Response> request(Uri uri, Object? body, Map<String, String>? headers) => http.get(uri, headers: headers);
-    return http.get(uri, headers: headers);
-  }
 
-}
+}

lib/api/marianumcloud/talk/getParticipants/getParticipantsCache.dart

@@ -8,19 +8,15 @@ class GetParticipantsCache extends RequestCache<GetParticipantsResponse> {
   String chatToken;
 
   GetParticipantsCache({required onUpdate, required this.chatToken}) : super(RequestCache.cacheNothing, onUpdate) {
-    start('MarianumMobile', 'nc-chat-participants-$chatToken');
+    start('nc-chat-participants-$chatToken');
   }
 
   @override
-  Future<GetParticipantsResponse> onLoad() {
+  Future<GetParticipantsResponse> onLoad() => GetParticipants(
-    return GetParticipants(
         chatToken,
     ).run();
-  }
 
   @override
-  GetParticipantsResponse onLocalData(String json) {
+  GetParticipantsResponse onLocalData(String json) => GetParticipantsResponse.fromJson(jsonDecode(json));
-    return GetParticipantsResponse.fromJson(jsonDecode(json));
-  }
 
-}
+}

lib/api/marianumcloud/talk/getParticipants/getParticipantsResponse.dart

@@ -69,4 +69,4 @@ enum GetParticipantsResponseObjectParticipantsInCallFlags {
   @JsonValue(2) providesAudio,
   @JsonValue(3) providesVideo,
   @JsonValue(4) usesSipDialIn
-}
+}

lib/api/marianumcloud/talk/getReactions/getReactions.dart

@@ -13,13 +13,9 @@ class GetReactions extends TalkApi<GetReactionsResponse> {
   GetReactions({required this.chatToken, required this.messageId}) : super('v1/reaction/$chatToken/$messageId', null);
 
   @override
-  assemble(String raw) {
+  assemble(String raw) => GetReactionsResponse.fromJson(jsonDecode(raw)['ocs']);
-    return GetReactionsResponse.fromJson(jsonDecode(raw)['ocs']);
-  }
 
   @override
-  Future<Response>? request(Uri uri, ApiParams? body, Map<String, String>? headers) {
+  Future<Response>? request(Uri uri, ApiParams? body, Map<String, String>? headers) => http.get(uri, headers: headers);
-    return http.get(uri, headers: headers);
-  }
 
-}
+}

lib/api/marianumcloud/talk/getReactions/getReactionsResponse.dart

@@ -30,4 +30,4 @@ class GetReactionsResponseObject {
 enum GetReactionsResponseObjectActorType {
   @JsonValue('guests') guests,
   @JsonValue('users') users,
-}
+}

lib/api/marianumcloud/talk/leaveRoom/leaveRoom.dart

@@ -9,12 +9,8 @@ class LeaveRoom extends TalkApi {
   LeaveRoom(this.chatToken) : super('v4/room/$chatToken/participants/self', null);
 
   @override
-  assemble(String raw) {
+  assemble(String raw) => null;
-    return null;
-  }
 
   @override
-  Future<Response> request(Uri uri, Object? body, Map<String, String>? headers) {
+  Future<Response> request(Uri uri, Object? body, Map<String, String>? headers) => http.delete(uri, headers: headers);
-    return http.delete(uri, headers: headers);
+}
-  }
-}

lib/api/marianumcloud/talk/reactMessage/reactMessage.dart

@@ -11,9 +11,7 @@ class ReactMessage extends TalkApi {
   ReactMessage({required this.chatToken, required this.messageId, required ReactMessageParams params}) : super('v1/reaction/$chatToken/$messageId', params);
 
   @override
-  assemble(String raw) {
+  assemble(String raw) => null;
-    return null;
-  }
 
   @override
   Future<Response>? request(Uri uri, ApiParams? body, Map<String, String>? headers) {
@@ -23,4 +21,4 @@ class ReactMessage extends TalkApi {
     return null;
   }
 
-}
+}

lib/api/marianumcloud/talk/reactMessage/reactMessageParams.dart

@@ -12,4 +12,4 @@ class ReactMessageParams extends ApiParams {
 
   factory ReactMessageParams.fromJson(Map<String, dynamic> json) => _$ReactMessageParamsFromJson(json);
   Map<String, dynamic> toJson() => _$ReactMessageParamsToJson(this);
-}
+}

lib/api/marianumcloud/talk/room/getRoom.dart

@@ -14,13 +14,9 @@ class GetRoom extends TalkApi<GetRoomResponse> {
 
 
   @override
-  GetRoomResponse assemble(String raw) {
+  GetRoomResponse assemble(String raw) => GetRoomResponse.fromJson(jsonDecode(raw)['ocs']);
-    return GetRoomResponse.fromJson(jsonDecode(raw)['ocs']);
-  }
 
   @override
-  Future<http.Response> request(Uri uri, Object? body, Map<String, String>? headers) {
+  Future<http.Response> request(Uri uri, Object? body, Map<String, String>? headers) => http.get(uri, headers: headers);
-    return http.get(uri, headers: headers);
-  }
 
-}
+}

lib/api/marianumcloud/talk/room/getRoomCache.dart

@@ -8,20 +8,16 @@ import 'getRoomResponse.dart';
 
 class GetRoomCache extends RequestCache<GetRoomResponse> {
   GetRoomCache({onUpdate, renew}) : super(RequestCache.cacheMinute, onUpdate, renew: renew) {
-    start('MarianumMobile', 'nc-rooms');
+    start('nc-rooms');
   }
 
   @override
-  GetRoomResponse onLocalData(String json) {
+  GetRoomResponse onLocalData(String json) => GetRoomResponse.fromJson(jsonDecode(json));
-    return GetRoomResponse.fromJson(jsonDecode(json));
-  }
 
   @override
-  Future<GetRoomResponse> onLoad() {
+  Future<GetRoomResponse> onLoad() => GetRoom(
-    return GetRoom(
       GetRoomParams(
         includeStatus: true,
       )
     ).run();
-  }
+}
-}

lib/api/marianumcloud/talk/room/getRoomParams.dart

@@ -22,4 +22,4 @@ class GetRoomParams extends ApiParams {
 enum GetRoomParamsStatusUpdate {
   @JsonValue(0) defaults,
   @JsonValue(1) keepAlive,
-}
+}

lib/api/marianumcloud/talk/room/getRoomResponse.dart

@@ -164,4 +164,4 @@ enum GetRoomResponseObjectMessageType {
   @JsonValue('comment_deleted') deletedComment,
   @JsonValue('system') system,
   @JsonValue('command') command,
-}
+}

lib/api/marianumcloud/talk/sendMessage/sendMessage.dart

@@ -10,9 +10,7 @@ class SendMessage extends TalkApi {
   SendMessage(this.chatToken, SendMessageParams params) : super('v1/chat/$chatToken', params);
 
   @override
-  assemble(String raw) {
+  assemble(String raw) => null;
-    return null;
-  }
 
   @override
   Future<Response>? request(Uri uri, ApiParams? body, Map<String, String>? headers) {
@@ -22,4 +20,4 @@ class SendMessage extends TalkApi {
     return null;
   }
   
-}
+}

lib/api/marianumcloud/talk/sendMessage/sendMessageParams.dart

@@ -7,10 +7,10 @@ part 'sendMessageParams.g.dart';
 @JsonSerializable(explicitToJson: true, includeIfNull: false)
 class SendMessageParams extends ApiParams {
   String message;
-  int? replyTo;
+  String? replyTo;
 
   SendMessageParams(this.message, {this.replyTo});
 
   factory SendMessageParams.fromJson(Map<String, dynamic> json) => _$SendMessageParamsFromJson(json);
   Map<String, dynamic> toJson() => _$SendMessageParamsToJson(this);
-}
+}

lib/api/marianumcloud/talk/sendMessage/sendMessageParams.g.dart

@@ -9,7 +9,7 @@ part of 'sendMessageParams.dart';
 SendMessageParams _$SendMessageParamsFromJson(Map<String, dynamic> json) =>
     SendMessageParams(
       json['message'] as String,
-      replyTo: json['replyTo'] as int?,
+      replyTo: json['replyTo'] as String?,
     );
 
 Map<String, dynamic> _$SendMessageParamsToJson(SendMessageParams instance) {

lib/api/marianumcloud/talk/sendMessage/sendMessageResponse.dart

@@ -2,4 +2,4 @@ import '../../../apiResponse.dart';
 
 class SendMessageResponse extends ApiResponse {
 
-}
+}

lib/api/marianumcloud/talk/setFavorite/setFavorite.dart

@@ -11,9 +11,7 @@ class SetFavorite extends TalkApi {
   SetFavorite(this.chatToken, this.favoriteState) : super('v4/room/$chatToken/favorite', null);
 
   @override
-  assemble(String raw) {
+  assemble(String raw) => null;
-    return null;
-  }
 
   @override
   Future<Response> request(Uri uri, Object? body, Map<String, String>? headers) {
@@ -24,4 +22,4 @@ class SetFavorite extends TalkApi {
     }
   }
 
-}
+}

lib/api/marianumcloud/talk/setReadMarker/setReadMarker.dart

@@ -15,9 +15,7 @@ class SetReadMarker extends TalkApi {
   }
 
   @override
-  assemble(String raw) {
+  assemble(String raw) => null;
-    return null;
-  }
 
   @override
   Future<Response> request(Uri uri, Object? body, Map<String, String>? headers) {
@@ -29,4 +27,4 @@ class SetReadMarker extends TalkApi {
     }
   }
 
-}
+}

lib/api/marianumcloud/talk/setReadMarker/setReadMarkerParams.dart

@@ -14,4 +14,4 @@ class SetReadMarkerParams extends ApiParams {
 
   factory SetReadMarkerParams.fromJson(Map<String, dynamic> json) => _$SetReadMarkerParamsFromJson(json);
   Map<String, dynamic> toJson() => _$SetReadMarkerParamsToJson(this);
-}
+}

lib/api/marianumcloud/talk/talkApi.dart

@@ -34,7 +34,7 @@ abstract class TalkApi<T extends ApiResponse?> extends ApiRequest {
       getParameters?.update(key, (value) => value.toString());
     });
 
-    Uri endpoint = Uri.https('${AccountData().buildHttpAuthString()}@${EndpointData().nextcloud().domain}', '${EndpointData().nextcloud().path}/ocs/v2.php/apps/spreed/api/$path', getParameters);
+    var endpoint = Uri.https('${AccountData().buildHttpAuthString()}@${EndpointData().nextcloud().domain}', '${EndpointData().nextcloud().path}/ocs/v2.php/apps/spreed/api/$path', getParameters);
 
     headers ??= {};
     headers?.putIfAbsent('Accept', () => 'application/json');
@@ -65,4 +65,4 @@ abstract class TalkApi<T extends ApiResponse?> extends ApiRequest {
     throw Exception('Error assembling Talk API response');
   }
 
-}
+}

lib/api/marianumcloud/talk/talkError.dart

@@ -6,7 +6,5 @@ class TalkError {
   TalkError(this.status, this.code, this.message);
 
   @override
-  String toString() {
+  String toString() => 'Talk - $status - ($code): $message';
-    return 'Talk - $status - ($code): $message';
+}
-  }
-}

lib/api/marianumcloud/webdav/queries/downloadFile/downloadFile.dart

@@ -19,4 +19,4 @@ class DownloadFile extends WebdavApi<DownloadFileParams> {
     // OpenFile.open(localPath);
     throw UnimplementedError();
   }
-}
+}

lib/api/marianumcloud/webdav/queries/downloadFile/downloadFileParams.dart

@@ -14,4 +14,4 @@ class DownloadFileParams extends ApiParams {
 
   factory DownloadFileParams.fromJson(Map<String, dynamic> json) => _$DownloadFileParamsFromJson(json);
   Map<String, dynamic> toJson() => _$DownloadFileParamsToJson(this);
-}
+}

lib/api/marianumcloud/webdav/queries/downloadFile/downloadFileResponse.dart

@@ -11,4 +11,4 @@ class DownloadFileResponse {
 
   factory DownloadFileResponse.fromJson(Map<String, dynamic> json) => _$DownloadFileResponseFromJson(json);
   Map<String, dynamic> toJson() => _$DownloadFileResponseToJson(this);
-}
+}

lib/api/marianumcloud/webdav/queries/listFiles/cacheableFile.dart

@@ -34,4 +34,4 @@ class CacheableFile {
 
   factory CacheableFile.fromJson(Map<String, dynamic> json) => _$CacheableFileFromJson(json);
   Map<String, dynamic> toJson() => _$CacheableFileToJson(this);
-}
+}

lib/api/marianumcloud/webdav/queries/listFiles/listFiles.dart

@@ -13,8 +13,8 @@ class ListFiles extends WebdavApi<ListFilesParams> {
 
   @override
   Future<ListFilesResponse> run() async {
-    List<WebDavFile> davFiles = (await (await WebdavApi.webdav).propfind(PathUri.parse(params.path))).toWebDavFiles();
+    var davFiles = (await (await WebdavApi.webdav).propfind(PathUri.parse(params.path))).toWebDavFiles();
-    Set<CacheableFile> files = davFiles.map(CacheableFile.fromDavFile).toSet();
+    var files = davFiles.map(CacheableFile.fromDavFile).toSet();
 
     // webdav handles subdirectories wrong, this is a fix
     // currently this fix is not needed anymore
@@ -30,4 +30,4 @@ class ListFiles extends WebdavApi<ListFilesParams> {
 
     return ListFilesResponse(files);
   }
-}
+}

lib/api/marianumcloud/webdav/queries/listFiles/listFilesCache.dart

@@ -11,19 +11,17 @@ class ListFilesCache extends RequestCache<ListFilesResponse> {
 
   ListFilesCache({required onUpdate, required this.path}) : super(RequestCache.cacheNothing, onUpdate) {
     var bytes = utf8.encode('MarianumMobile-$path');
-    String cacheName = md5.convert(bytes).toString();
+    var cacheName = md5.convert(bytes).toString();
-    start('MarianumMobile', 'wd-folder-$cacheName');
+    start('wd-folder-$cacheName');
   }
 
   @override
   Future<ListFilesResponse> onLoad() async {
-    ListFilesResponse data = await ListFiles(ListFilesParams(path)).run();
+    var data = await ListFiles(ListFilesParams(path)).run();
     return data;
   }
 
   @override
-  ListFilesResponse onLocalData(String json) {
+  ListFilesResponse onLocalData(String json) => ListFilesResponse.fromJson(jsonDecode(json));
-    return ListFilesResponse.fromJson(jsonDecode(json));
-  }
 
-}
+}

lib/api/marianumcloud/webdav/queries/listFiles/listFilesParams.dart

@@ -12,4 +12,4 @@ class ListFilesParams extends ApiParams {
 
   factory ListFilesParams.fromJson(Map<String, dynamic> json) => _$ListFilesParamsFromJson(json);
   Map<String, dynamic> toJson() => _$ListFilesParamsToJson(this);
-}
+}

lib/api/marianumcloud/webdav/queries/listFiles/listFilesResponse.dart

@@ -54,4 +54,4 @@ class ListFilesResponse extends ApiResponse {
         var list = files.toList()..sort((a, b) => b.sort!.compareTo(a.sort!));
         return reversed ? list.reversed.toList() : list;
     }
-}
+}

lib/api/marianumcloud/webdav/webdavApi.dart

@@ -17,11 +17,7 @@ abstract class WebdavApi<T> extends ApiRequest {
   static Future<WebDavClient> webdav = establishWebdavConnection();
   static Future<String> webdavConnectString = buildWebdavConnectString();
 
-  static Future<WebDavClient> establishWebdavConnection() async {
+  static Future<WebDavClient> establishWebdavConnection() async => NextcloudClient(Uri.parse('https://${EndpointData().nextcloud().full()}'), password: AccountData().getPassword(), loginName: AccountData().getUsername()).webdav;
-    return NextcloudClient(Uri.parse('https://${EndpointData().nextcloud().full()}'), password: AccountData().getPassword(), loginName: AccountData().getUsername()).webdav;
-  }
 
-  static Future<String> buildWebdavConnectString() async {
+  static Future<String> buildWebdavConnectString() async => 'https://${AccountData().buildHttpAuthString()}@${EndpointData().nextcloud().full()}/remote.php/dav/files/${AccountData().getUsername()}/';
-    return 'https://${AccountData().buildHttpAuthString()}@${EndpointData().nextcloud().full()}/remote.php/dav/files/${AccountData().getUsername()}/';
+}
-  }
-}

lib/api/mhsl/breaker/getBreakers/getBreakers.dart

@@ -9,13 +9,9 @@ class GetBreakers extends MhslApi<GetBreakersResponse> {
   GetBreakers() : super('breaker/');
 
   @override
-  GetBreakersResponse assemble(String raw) {
+  GetBreakersResponse assemble(String raw) => GetBreakersResponse.fromJson(jsonDecode(raw));
-    return GetBreakersResponse.fromJson(jsonDecode(raw));
-  }
 
   @override
-  Future<Response>? request(Uri uri) {
+  Future<Response>? request(Uri uri) => http.get(uri);
-    return http.get(uri);
-  }
 
-}
+}

lib/api/mhsl/breaker/getBreakers/getBreakersCache.dart

@@ -6,16 +6,12 @@ import 'getBreakersResponse.dart';
 
 class GetBreakersCache extends RequestCache<GetBreakersResponse> {
   GetBreakersCache({onUpdate, renew}) : super(RequestCache.cacheMinute, onUpdate, renew: renew) {
-    start('MarianumMobile', 'breakers');
+    start('breakers');
   }
 
   @override
-  GetBreakersResponse onLocalData(String json) {
+  GetBreakersResponse onLocalData(String json) => GetBreakersResponse.fromJson(jsonDecode(json));
-    return GetBreakersResponse.fromJson(jsonDecode(json));
-  }
 
   @override
-  Future<GetBreakersResponse> onLoad() {
+  Future<GetBreakersResponse> onLoad() => GetBreakers().run();
-    return GetBreakers().run();
+}
-  }
-}

lib/api/mhsl/breaker/getBreakers/getBreakersResponse.dart

@@ -33,4 +33,4 @@ enum BreakerArea {
   @JsonValue('TALK') talk,
   @JsonValue('FILES') files,
   @JsonValue('MORE') more,
-}
+}

lib/api/mhsl/customTimetableEvent/add/addCustomTimetableEvent.dart

@@ -16,7 +16,7 @@ class AddCustomTimetableEvent extends MhslApi<void> {
 
   @override
   Future<Response>? request(Uri uri) {
-    String body = jsonEncode(params.toJson());
+    var body = jsonEncode(params.toJson());
     return http.post(uri, body: body);
   }
-}
+}

lib/api/mhsl/customTimetableEvent/add/addCustomTimetableEventParams.dart

@@ -13,4 +13,4 @@ class AddCustomTimetableEventParams {
 
   factory AddCustomTimetableEventParams.fromJson(Map<String, dynamic> json) => _$AddCustomTimetableEventParamsFromJson(json);
   Map<String, dynamic> toJson() => _$AddCustomTimetableEventParamsToJson(this);
-}
+}

lib/api/mhsl/customTimetableEvent/customTimetableEvent.dart

@@ -25,4 +25,4 @@ class CustomTimetableEvent {
 
   factory CustomTimetableEvent.fromJson(Map<String, dynamic> json) => _$CustomTimetableEventFromJson(json);
   Map<String, dynamic> toJson() => _$CustomTimetableEventToJson(this);
-}
+}

lib/api/mhsl/customTimetableEvent/get/getCustomTimetableEvent.dart

@@ -12,12 +12,8 @@ class GetCustomTimetableEvent extends MhslApi<GetCustomTimetableEventResponse> {
   GetCustomTimetableEvent(this.params) : super('server/timetable/customEvents?user=${params.user}');
 
   @override
-  GetCustomTimetableEventResponse assemble(String raw) {
+  GetCustomTimetableEventResponse assemble(String raw) => GetCustomTimetableEventResponse.fromJson({'events': jsonDecode(raw)});
-    return GetCustomTimetableEventResponse.fromJson({'events': jsonDecode(raw)});
-  }
 
   @override
-  Future<Response>? request(Uri uri) {
+  Future<Response>? request(Uri uri) => http.get(uri);
-    return http.get(uri);
+}
-  }
-}

lib/api/mhsl/customTimetableEvent/get/getCustomTimetableEventCache.dart

@@ -9,16 +9,12 @@ class GetCustomTimetableEventCache extends RequestCache<GetCustomTimetableEventR
   GetCustomTimetableEventParams params;
 
   GetCustomTimetableEventCache(this.params, {onUpdate, renew}) : super(RequestCache.cacheMinute, onUpdate, renew: renew) {
-    start('MarianumMobile', 'customTimetableEvents');
+    start('customTimetableEvents');
   }
 
   @override
-  Future<GetCustomTimetableEventResponse> onLoad() {
+  Future<GetCustomTimetableEventResponse> onLoad() => GetCustomTimetableEvent(params).run();
-    return GetCustomTimetableEvent(params).run();
-  }
 
   @override
-  GetCustomTimetableEventResponse onLocalData(String json) {
+  GetCustomTimetableEventResponse onLocalData(String json) => GetCustomTimetableEventResponse.fromJson(jsonDecode(json));
-    return GetCustomTimetableEventResponse.fromJson(jsonDecode(json));
+}
-  }
-}

lib/api/mhsl/customTimetableEvent/get/getCustomTimetableEventParams.dart

@@ -10,4 +10,4 @@ class GetCustomTimetableEventParams {
 
   factory GetCustomTimetableEventParams.fromJson(Map<String, dynamic> json) => _$GetCustomTimetableEventParamsFromJson(json);
   Map<String, dynamic> toJson() => _$GetCustomTimetableEventParamsToJson(this);
-}
+}

lib/api/mhsl/customTimetableEvent/get/getCustomTimetableEventResponse.dart

@@ -13,4 +13,4 @@ class GetCustomTimetableEventResponse extends ApiResponse {
 
   factory GetCustomTimetableEventResponse.fromJson(Map<String, dynamic> json) => _$GetCustomTimetableEventResponseFromJson(json);
   Map<String, dynamic> toJson() => _$GetCustomTimetableEventResponseToJson(this);
-}
+}

lib/api/mhsl/customTimetableEvent/remove/removeCustomTimetableEvent.dart

@@ -15,7 +15,5 @@ class RemoveCustomTimetableEvent extends MhslApi<void> {
   void assemble(String raw) {}
 
   @override
-  Future<Response>? request(Uri uri) {
+  Future<Response>? request(Uri uri) => http.delete(uri, body: jsonEncode(params.toJson()));
-    return http.delete(uri, body: jsonEncode(params.toJson()));
+}
-  }
-}

lib/api/mhsl/customTimetableEvent/remove/removeCustomTimetableEventParams.dart

@@ -10,4 +10,4 @@ class RemoveCustomTimetableEventParams {
 
   factory RemoveCustomTimetableEventParams.fromJson(Map<String, dynamic> json) => _$RemoveCustomTimetableEventParamsFromJson(json);
   Map<String, dynamic> toJson() => _$RemoveCustomTimetableEventParamsToJson(this);
-}
+}

lib/api/mhsl/customTimetableEvent/update/updateCustomTimetableEvent.dart

@@ -15,7 +15,5 @@ class UpdateCustomTimetableEvent extends MhslApi<void> {
   void assemble(String raw) {}
 
   @override
-  Future<Response>? request(Uri uri) {
+  Future<Response>? request(Uri uri) => http.patch(uri, body: jsonEncode(params.toJson()));
-    return http.patch(uri, body: jsonEncode(params.toJson()));
+}
-  }
-}

lib/api/mhsl/customTimetableEvent/update/updateCustomTimetableEventParams.dart

@@ -14,4 +14,4 @@ class UpdateCustomTimetableEventParams {
 
   factory UpdateCustomTimetableEventParams.fromJson(Map<String, dynamic> json) => _$UpdateCustomTimetableEventParamsFromJson(json);
   Map<String, dynamic> toJson() => _$UpdateCustomTimetableEventParamsToJson(this);
-}
+}

lib/api/mhsl/message/getMessages/getMessages.dart

@@ -1,21 +0,0 @@
-import 'dart:convert';
-
-import 'package:http/http.dart' as http;
-
-import '../../mhslApi.dart';
-import 'getMessagesResponse.dart';
-
-class GetMessages extends MhslApi<GetMessagesResponse> {
-  GetMessages() : super('message/messages.json');
-
-
-  @override
-  GetMessagesResponse assemble(String raw) {
-    return GetMessagesResponse.fromJson(jsonDecode(raw));
-  }
-
-  @override
-  Future<http.Response> request(Uri uri) {
-    return http.get(uri);
-  }
-}

lib/api/mhsl/message/getMessages/getMessagesCache.dart

@@ -1,21 +0,0 @@
-import 'dart:convert';
-
-import '../../../requestCache.dart';
-import 'getMessages.dart';
-import 'getMessagesResponse.dart';
-
-class GetMessagesCache extends RequestCache<GetMessagesResponse> {
-  GetMessagesCache({onUpdate, renew}) : super(RequestCache.cacheMinute, onUpdate, renew: renew) {
-    start('MarianumMobile', 'message');
-  }
-
-  @override
-  GetMessagesResponse onLocalData(String json) {
-    return GetMessagesResponse.fromJson(jsonDecode(json));
-  }
-
-  @override
-  Future<GetMessagesResponse> onLoad() {
-    return GetMessages().run();
-  }
-}

lib/api/mhsl/message/getMessages/getMessagesResponse.dart

@@ -1,28 +0,0 @@
-import 'package:json_annotation/json_annotation.dart';
-
-import '../../../apiResponse.dart';
-
-part 'getMessagesResponse.g.dart';
-
-@JsonSerializable(explicitToJson: true)
-class GetMessagesResponse extends ApiResponse {
-  String base;
-  Set<GetMessagesResponseObject> messages;
-
-  GetMessagesResponse(this.base, this.messages);
-
-  factory GetMessagesResponse.fromJson(Map<String, dynamic> json) => _$GetMessagesResponseFromJson(json);
-  Map<String, dynamic> toJson() => _$GetMessagesResponseToJson(this);
-}
-
-@JsonSerializable(explicitToJson: true)
-class GetMessagesResponseObject {
-  String name;
-  String date;
-  String url;
-
-  GetMessagesResponseObject(this.name, this.date, this.url);
-
-  factory GetMessagesResponseObject.fromJson(Map<String, dynamic> json) => _$GetMessagesResponseObjectFromJson(json);
-  Map<String, dynamic> toJson() => _$GetMessagesResponseObjectToJson(this);
-}

lib/api/mhsl/message/getMessages/getMessagesResponse.g.dart

@@ -1,49 +0,0 @@
-// GENERATED CODE - DO NOT MODIFY BY HAND
-
-part of 'getMessagesResponse.dart';
-
-// **************************************************************************
-// JsonSerializableGenerator
-// **************************************************************************
-
-GetMessagesResponse _$GetMessagesResponseFromJson(Map<String, dynamic> json) =>
-    GetMessagesResponse(
-      json['base'] as String,
-      (json['messages'] as List<dynamic>)
-          .map((e) =>
-              GetMessagesResponseObject.fromJson(e as Map<String, dynamic>))
-          .toSet(),
-    )..headers = (json['headers'] as Map<String, dynamic>?)?.map(
-        (k, e) => MapEntry(k, e as String),
-      );
-
-Map<String, dynamic> _$GetMessagesResponseToJson(GetMessagesResponse instance) {
-  final val = <String, dynamic>{};
-
-  void writeNotNull(String key, dynamic value) {
-    if (value != null) {
-      val[key] = value;
-    }
-  }
-
-  writeNotNull('headers', instance.headers);
-  val['base'] = instance.base;
-  val['messages'] = instance.messages.map((e) => e.toJson()).toList();
-  return val;
-}
-
-GetMessagesResponseObject _$GetMessagesResponseObjectFromJson(
-        Map<String, dynamic> json) =>
-    GetMessagesResponseObject(
-      json['name'] as String,
-      json['date'] as String,
-      json['url'] as String,
-    );
-
-Map<String, dynamic> _$GetMessagesResponseObjectToJson(
-        GetMessagesResponseObject instance) =>
-    <String, dynamic>{
-      'name': instance.name,
-      'date': instance.date,
-      'url': instance.url,
-    };

lib/api/mhsl/mhslApi.dart

@@ -15,9 +15,9 @@ abstract class MhslApi<T> extends ApiRequest {
   T assemble(String raw);
 
   Future<T> run() async {
-    Uri endpoint = Uri.parse('https://mhsl.eu/marianum/marianummobile/$subpath');
+    var endpoint = Uri.parse('https://mhsl.eu/marianum/marianummobile/$subpath');
 
-    http.Response? data = await request(endpoint);
+    var data = await request(endpoint);
     if(data == null) {
       throw ApiError('Request could not be dispatched!');
     }
@@ -31,5 +31,4 @@ abstract class MhslApi<T> extends ApiRequest {
 
   static String dateTimeToJson(DateTime time) => Jiffy.parseFromDateTime(time).format(pattern: 'yyyy-MM-dd HH:mm:ss');
   static DateTime dateTimeFromJson(String time) => DateTime.parse(time);
-
+}
-}

lib/api/mhsl/notify/register/notifyRegister.dart

@@ -19,8 +19,8 @@ class NotifyRegister extends MhslApi<void> {
 
   @override
   Future<http.Response> request(Uri uri) {
-    String requestString = jsonEncode(params.toJson());
+    var requestString = jsonEncode(params.toJson());
     log(requestString);
     return http.post(uri, body: requestString);
   }
-}
+}

lib/api/mhsl/notify/register/notifyRegisterParams.dart

@@ -16,4 +16,4 @@ class NotifyRegisterParams {
 
   factory NotifyRegisterParams.fromJson(Map<String, dynamic> json) => _$NotifyRegisterParamsFromJson(json);
   Map<String, dynamic> toJson() => _$NotifyRegisterParamsToJson(this);
-}
+}

lib/api/mhsl/server/feedback/addFeedback.dart

@@ -15,7 +15,5 @@ class AddFeedback extends MhslApi<void> {
   void assemble(String raw) {}
 
   @override
-  Future<Response>? request(Uri uri) {
+  Future<Response>? request(Uri uri) => http.post(uri, body: jsonEncode(params.toJson()));
-    return http.post(uri, body: jsonEncode(params.toJson()));
+}
-  }
-}

lib/api/mhsl/server/feedback/addFeedbackParams.dart

@@ -6,15 +6,17 @@ part 'addFeedbackParams.g.dart';
 class AddFeedbackParams {
   String user;
   String feedback;
+  String? screenshot;
   int appVersion;
 
 
   AddFeedbackParams({
     required this.user,
     required this.feedback,
+    this.screenshot,
     required this.appVersion,
   });
 
   factory AddFeedbackParams.fromJson(Map<String, dynamic> json) => _$AddFeedbackParamsFromJson(json);
   Map<String, dynamic> toJson() => _$AddFeedbackParamsToJson(this);
-}
+}

lib/api/mhsl/server/feedback/addFeedbackParams.g.dart

@@ -10,6 +10,7 @@ AddFeedbackParams _$AddFeedbackParamsFromJson(Map<String, dynamic> json) =>
     AddFeedbackParams(
       user: json['user'] as String,
       feedback: json['feedback'] as String,
+      screenshot: json['screenshot'] as String?,
       appVersion: json['appVersion'] as int,
     );
 
@@ -17,5 +18,6 @@ Map<String, dynamic> _$AddFeedbackParamsToJson(AddFeedbackParams instance) =>
     <String, dynamic>{
       'user': instance.user,
       'feedback': instance.feedback,
+      'screenshot': instance.screenshot,
       'appVersion': instance.appVersion,
     };

lib/api/mhsl/server/userIndex/update/updateUserIndexParams.dart

@@ -21,4 +21,4 @@ class UpdateUserIndexParams {
 
   factory UpdateUserIndexParams.fromJson(Map<String, dynamic> json) => _$UpdateUserIndexParamsFromJson(json);
   Map<String, dynamic> toJson() => _$UpdateUserIndexParamsToJson(this);
-}
+}

lib/api/mhsl/server/userIndex/update/updateUserindex.dart

@@ -19,12 +19,12 @@ class UpdateUserIndex extends MhslApi<void> {
 
   @override
   Future<http.Response> request(Uri uri) {
-    String data = jsonEncode(params.toJson());
+    var data = jsonEncode(params.toJson());
     log('Updating userindex:\n $data');
     return http.post(uri, body: data);
   }
 
-  static void index() async {
+  static Future<void> index() async {
     UpdateUserIndex(
       UpdateUserIndexParams(
         username: AccountData().getUsername(),
@@ -35,4 +35,4 @@ class UpdateUserIndex extends MhslApi<void> {
       ),
     ).run();
   }
-}
+}

lib/api/requestCache.dart

@@ -11,6 +11,8 @@ abstract class RequestCache<T extends ApiResponse?> {
   static const int cacheHour = 60 * 60;
   static const int cacheDay = 60 * 60 * 24;
 
+  static String collection = 'MarianumMobile';
+
   int maxCacheTime;
   Function(T) onUpdate;
   Function(Exception) onError;
@@ -20,8 +22,8 @@ abstract class RequestCache<T extends ApiResponse?> {
 
   static void ignore(Exception e) {}
 
-  void start(String file, String document) async {
+  Future<void> start(String document) async {
-    Map<String, dynamic>? tableData = await Localstore.instance.collection(file).doc(document).get();
+    var tableData = await Localstore.instance.collection(collection).doc(document).get();
     if(tableData != null) {
       onUpdate(onLocalData(tableData['json']));
     }
@@ -31,10 +33,10 @@ abstract class RequestCache<T extends ApiResponse?> {
     }
 
     try {
-      T newValue = await onLoad();
+      var newValue = await onLoad();
       onUpdate(newValue);
 
-      Localstore.instance.collection(file).doc(document).set({
+      Localstore.instance.collection(collection).doc(document).set({
         'json': jsonEncode(newValue),
         'lastupdate': DateTime.now().millisecondsSinceEpoch
       });
@@ -46,4 +48,4 @@ abstract class RequestCache<T extends ApiResponse?> {
   T onLocalData(String json);
   Future<T> onLoad();
 
-}
+}

lib/api/webuntis/queries/authenticate/authenticate.dart

@@ -14,7 +14,7 @@ class Authenticate extends WebuntisApi {
   @override
   Future<AuthenticateResponse> run() async {
     awaitingResponse = true;
-    String rawAnswer = await query(this);
+    var rawAnswer = await query(this);
     AuthenticateResponse response = finalize(AuthenticateResponse.fromJson(jsonDecode(rawAnswer)['result']));
     _lastResponse = response;
     if(!awaitedResponse.isCompleted) awaitedResponse.complete();
@@ -46,4 +46,4 @@ class Authenticate extends WebuntisApi {
     return _lastResponse!;
 
   }
-}
+}

lib/api/webuntis/queries/authenticate/authenticateParams.dart

@@ -14,4 +14,4 @@ class AuthenticateParams extends ApiParams {
   factory AuthenticateParams.fromJson(Map<String, dynamic> json) => _$AuthenticateParamsFromJson(json);
 
   Map<String, dynamic> toJson() => _$AuthenticateParamsToJson(this);
-}
+}

lib/api/webuntis/queries/authenticate/authenticateResponse.dart

@@ -16,4 +16,4 @@ class AuthenticateResponse extends ApiResponse {
 
   factory AuthenticateResponse.fromJson(Map<String, dynamic> json) => _$AuthenticateResponseFromJson(json);
   Map<String, dynamic> toJson() => _$AuthenticateResponseToJson(this);
-}
+}

lib/api/webuntis/queries/getHolidays/getHolidays.dart

@@ -8,7 +8,7 @@ class GetHolidays extends WebuntisApi {
 
   @override
   Future<GetHolidaysResponse> run() async {
-    String rawAnswer = await query(this);
+    var rawAnswer = await query(this);
     return finalize(GetHolidaysResponse.fromJson(jsonDecode(rawAnswer)));
   }
 
@@ -17,12 +17,12 @@ class GetHolidays extends WebuntisApi {
     time = DateTime(time.year, time.month, time.day, 0, 0, 0, 0, 0);
 
     for (var element in holidaysResponse.result) {
-      DateTime start = DateTime.parse(element.startDate.toString());
+      var start = DateTime.parse(element.startDate.toString());
-      DateTime end = DateTime.parse(element.endDate.toString());
+      var end = DateTime.parse(element.endDate.toString());
 
       if(!start.isAfter(time) && !end.isBefore(time)) return element;
     }
     return null;
   }
 
-}
+}

lib/api/webuntis/queries/getHolidays/getHolidaysCache.dart

@@ -6,16 +6,12 @@ import 'getHolidaysResponse.dart';
 
 class GetHolidaysCache extends RequestCache<GetHolidaysResponse> {
   GetHolidaysCache({onUpdate}) : super(RequestCache.cacheDay, onUpdate) {
-    start('MarianumMobile', 'wu-holidays');
+    start('wu-holidays');
   }
 
   @override
-  Future<GetHolidaysResponse> onLoad() {
+  Future<GetHolidaysResponse> onLoad() => GetHolidays().run();
-    return GetHolidays().run();
-  }
 
   @override
-  GetHolidaysResponse onLocalData(String json) {
+  GetHolidaysResponse onLocalData(String json) => GetHolidaysResponse.fromJson(jsonDecode(json));
-    return GetHolidaysResponse.fromJson(jsonDecode(json));
+}
-  }
-}

lib/api/webuntis/queries/getHolidays/getHolidaysResponse.dart

@@ -26,4 +26,4 @@ class GetHolidaysResponseObject {
 
   factory GetHolidaysResponseObject.fromJson(Map<String, dynamic> json) => _$GetHolidaysResponseObjectFromJson(json);
   Map<String, dynamic> toJson() => _$GetHolidaysResponseObjectToJson(this);
-}
+}

lib/api/webuntis/queries/getRooms/getRooms.dart

@@ -9,7 +9,7 @@ class GetRooms extends WebuntisApi {
 
   @override
   Future<GetRoomsResponse> run() async {
-    String rawAnswer = await query(this);
+    var rawAnswer = await query(this);
     try {
       return finalize(GetRoomsResponse.fromJson(jsonDecode(rawAnswer)));
     } catch(e, trace) {
@@ -20,4 +20,4 @@ class GetRooms extends WebuntisApi {
     throw Exception('Failed to parse getRoom server response: $rawAnswer');
   }
 
-}
+}

lib/api/webuntis/queries/getRooms/getRoomsCache.dart

@@ -6,17 +6,13 @@ import 'getRoomsResponse.dart';
 
 class GetRoomsCache extends RequestCache<GetRoomsResponse> {
   GetRoomsCache({onUpdate}) : super(RequestCache.cacheHour, onUpdate) {
-    start('MarianumMobile', 'wu-rooms');
+    start('wu-rooms');
   }
 
   @override
-  Future<GetRoomsResponse> onLoad() {
+  Future<GetRoomsResponse> onLoad() => GetRooms().run();
-    return GetRooms().run();
-  }
 
   @override
-  GetRoomsResponse onLocalData(String json) {
+  GetRoomsResponse onLocalData(String json) => GetRoomsResponse.fromJson(jsonDecode(json));
-    return GetRoomsResponse.fromJson(jsonDecode(json));
-  }
 
-}
+}

lib/api/webuntis/queries/getRooms/getRoomsResponse.dart

@@ -26,4 +26,4 @@ class GetRoomsResponseObject {
 
   factory GetRoomsResponseObject.fromJson(Map<String, dynamic> json) => _$GetRoomsResponseObjectFromJson(json);
   Map<String, dynamic> toJson() => _$GetRoomsResponseObjectToJson(this);
-}
+}

lib/api/webuntis/queries/getSubjects/getSubjects.dart

@@ -8,7 +8,7 @@ class GetSubjects extends WebuntisApi {
 
   @override
   Future<GetSubjectsResponse> run() async {
-    String rawAnswer = await query(this);
+    var rawAnswer = await query(this);
     return finalize(GetSubjectsResponse.fromJson(jsonDecode(rawAnswer)));
   }
-}
+}

lib/api/webuntis/queries/getSubjects/getSubjectsCache.dart

@@ -6,17 +6,13 @@ import 'getSubjectsResponse.dart';
 
 class GetSubjectsCache extends RequestCache<GetSubjectsResponse> {
   GetSubjectsCache({onUpdate}) : super(RequestCache.cacheHour, onUpdate) {
-    start('MarianumMobile', 'wu-subjects');
+    start('wu-subjects');
   }
 
   @override
-  Future<GetSubjectsResponse> onLoad() {
+  Future<GetSubjectsResponse> onLoad() => GetSubjects().run();
-    return GetSubjects().run();
-  }
 
   @override
-  onLocalData(String json) {
+  onLocalData(String json) => GetSubjectsResponse.fromJson(jsonDecode(json));
-    return GetSubjectsResponse.fromJson(jsonDecode(json));
-  }
 
-}
+}

lib/api/webuntis/queries/getSubjects/getSubjectsResponse.dart

@@ -26,4 +26,4 @@ class GetSubjectsResponseObject {
 
   factory GetSubjectsResponseObject.fromJson(Map<String, dynamic> json) => _$GetSubjectsResponseObjectFromJson(json);
   Map<String, dynamic> toJson() => _$GetSubjectsResponseObjectToJson(this);
-}
+}

lib/api/webuntis/queries/getTimetable/getTimetable.dart

@@ -11,8 +11,8 @@ class GetTimetable extends WebuntisApi {
 
   @override
   Future<GetTimetableResponse> run() async {
-    String rawAnswer = await query(this);
+    var rawAnswer = await query(this);
     return finalize(GetTimetableResponse.fromJson(jsonDecode(rawAnswer)));
   }
 
-}
+}

lib/api/webuntis/queries/getTimetable/getTimetableCache.dart

@@ -11,17 +11,14 @@ class GetTimetableCache extends RequestCache<GetTimetableResponse> {
   int enddate;
 
   GetTimetableCache({required onUpdate, onError, required this.startdate, required this.enddate}) : super(RequestCache.cacheMinute, onUpdate, onError: onError) {
-    start('MarianumMobile', 'wu-timetable-$startdate-$enddate');
+    start('wu-timetable-$startdate-$enddate');
   }
 
   @override
-  GetTimetableResponse onLocalData(String json) {
+  GetTimetableResponse onLocalData(String json) => GetTimetableResponse.fromJson(jsonDecode(json));
-    return GetTimetableResponse.fromJson(jsonDecode(json));
-  }
 
   @override
-  Future<GetTimetableResponse> onLoad() async {
+  Future<GetTimetableResponse> onLoad() async => GetTimetable(
-    return GetTimetable(
         GetTimetableParams(
             options: GetTimetableParamsOptions(
                 element: GetTimetableParamsOptionsElement(
@@ -38,5 +35,4 @@ class GetTimetableCache extends RequestCache<GetTimetableResponse> {
         )
     )
     ).run();
-  }
+}
-}

lib/api/webuntis/queries/getTimetable/getTimetableParams.dart

@@ -91,4 +91,4 @@ enum GetTimetableParamsOptionsElementKeyType {
   @JsonValue('id') id,
   @JsonValue('name') name,
   @JsonValue('externalkey') externalkey
-}
+}

lib/api/webuntis/queries/getTimetable/getTimetableResponse.dart

@@ -136,4 +136,4 @@ class GetTimetableResponseObjectRoom {
 
   factory GetTimetableResponseObjectRoom.fromJson(Map<String, dynamic> json) => _$GetTimetableResponseObjectRoomFromJson(json);
   Map<String, dynamic> toJson() => _$GetTimetableResponseObjectRoomToJson(this);
-}
+}

lib/api/webuntis/webuntisApi.dart

@@ -20,13 +20,13 @@ abstract class WebuntisApi extends ApiRequest {
 
 
   Future<String> query(WebuntisApi untis) async {
-    String query = '{"id":"ID","method":"$method","params":${untis._body()},"jsonrpc":"2.0"}';
+    var query = '{"id":"ID","method":"$method","params":${untis._body()},"jsonrpc":"2.0"}';
 
-    String sessionId = '0';
+    var sessionId = '0';
     if(authenticatedResponse) {
       sessionId = (await Authenticate.getSession()).sessionId;
     }
-    http.Response data = await post(query, {'Cookie': 'JSESSIONID=$sessionId'});
+    var data = await post(query, {'Cookie': 'JSESSIONID=$sessionId'});
     response = data;
 
     dynamic jsonData = jsonDecode(data.body);
@@ -48,16 +48,12 @@ abstract class WebuntisApi extends ApiRequest {
 
   Future<ApiResponse> run();
 
-  String _body() {
+  String _body() => genericParam == null ? '{}' : jsonEncode(genericParam);
-    return genericParam == null ? '{}' : jsonEncode(genericParam);
-  }
 
-  Future<http.Response> post(String data, Map<String, String>? headers) async {
+  Future<http.Response> post(String data, Map<String, String>? headers) async => await http
-    return await http
         .post(endpoint, body: data, headers: headers)
         .timeout(
         const Duration(seconds: 10),
         onTimeout: () => throw WebuntisError('Timeout', 1)
     );
-  }
+}
-}