MarianumMobile/Client
MarianumMobile/Client
5
1
Fork 0
Code Issues 33 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

added option to choose more emoji reactions #55

Merged
MineTec merged 8 commits from develop-moreEmojiReactions into develop 2024-04-02 16:51:33 +00:00
Conversation 4 Commits 8 Files Changed 4 +83 -6
Pupsi commented 2024-04-02 12:16:09 +00:00
Member
Copy Link

#46

#46
Pupsi added 1 commit 2024-04-02 12:16:10 +00:00
Pupsi added 1 commit 2024-04-02 12:34:45 +00:00
MineTec reviewed 2024-04-02 13:00:03 +00:00
lib/view/pages/talk/components/chatBubble.dart Outdated
@ -214,0 +283,4 @@
const SizedBox(
width: 1,
height: 25,
child: null,
MineTec commented 2024-04-02 13:00:03 +00:00
Owner
Copy Link

width ist nullable, daher brauchst du keinen platzhalter wie 1 angeben. Parameter die Null sind können ganz weggelassen werden.

width ist nullable, daher brauchst du keinen platzhalter wie 1 angeben. Parameter die Null sind können ganz weggelassen werden.
Pupsi marked this conversation as resolved
MineTec reviewed 2024-04-02 13:02:37 +00:00
lib/view/pages/talk/components/chatBubble.dart Outdated
@ -214,0 +233,4 @@
const SizedBox(
width: 10,
height: 0,
child: null,
MineTec commented 2024-04-02 13:02:37 +00:00
Owner
Copy Link

hight und child müssen nicht angegeben werden

hight und child müssen nicht angegeben werden
Pupsi marked this conversation as resolved
MineTec reviewed 2024-04-02 13:03:45 +00:00
lib/view/pages/talk/components/chatBubble.dart Outdated
@ -214,0 +243,4 @@
children: [
emojis.EmojiPicker(
onBackspacePressed: () {
null;
MineTec commented 2024-04-02 13:03:45 +00:00
Owner
Copy Link

ist onBackspacePressed nullable? Falls ja den parameter nicht angeben.

Ansonsten das null statement weg und die curly braces einfach leer lassen. In diesem Fall dürfen die curlybraces auch in der selben Zeile stehen "{ }"

ist onBackspacePressed nullable? Falls ja den parameter nicht angeben. Ansonsten das null statement weg und die curly braces einfach leer lassen. In diesem Fall dürfen die curlybraces auch in der selben Zeile stehen "{ }"
Pupsi marked this conversation as resolved
Pupsi added 1 commit 2024-04-02 13:48:08 +00:00
Pupsi added 1 commit 2024-04-02 13:51:17 +00:00
Pupsi added 1 commit 2024-04-02 16:11:04 +00:00
Pupsi added 1 commit 2024-04-02 16:24:20 +00:00
Pupsi added 1 commit 2024-04-02 16:26:35 +00:00
Pupsi added 1 commit 2024-04-02 16:30:20 +00:00
MineTec reviewed 2024-04-02 16:42:19 +00:00
lib/view/pages/talk/components/chatBubble.dart
@ -214,0 +237,4 @@
content: SizedBox(
width: 256,
height: 270,
child: Column(
MineTec commented 2024-04-02 16:42:19 +00:00
Owner
Copy Link

wofür existiert diese column?

wofür existiert diese column?
Pupsi marked this conversation as resolved
MineTec merged commit bc60362984 into develop 2024-04-02 16:51:33 +00:00
MineTec deleted branch develop-moreEmojiReactions 2024-04-02 16:51:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
feedback
Feedback von Nutzer
help wanted
Need some help
question
More information is needed
technnical
Not user facing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bytedream goldbaja MineTec olischma Pupsi
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarianumMobile/Client#55
No description provided.
Delete Branch "develop-moreEmojiReactions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?