MarianumMobile/Client
5
1
Fork 0
Code Issues 33 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

develop-unfocusTextField #56

Merged
MineTec merged 4 commits from develop-unfocusTextField into develop 2024-04-02 14:55:36 +00:00
Conversation 6 Commits 4 Files Changed 6 +15 -24
Pupsi commented 2024-04-02 13:04:18 +00:00
Member
Copy Link

#54

#54
Pupsi added 3 commits 2024-04-02 13:04:18 +00:00
added unfocus when tapping on background image 42574583ed
added unfocus when tapping outside textfield 339d402422
added unfocus at textfields for custon events and feedback 21411e1517
MineTec reviewed 2024-04-02 13:12:56 +00:00
lib/view/pages/talk/chatView.dart Outdated
@@ -117,3 +113,1 @@
repeat: ImageRepeat.repeat,
invertColors: AppTheme.isDarkMode(context)
)
image: DecorationImage(
MineTec commented 2024-04-02 13:12:56 +00:00
Owner
Copy Link

tabs bitte reverten

tabs bitte reverten
Pupsi marked this conversation as resolved
MineTec reviewed 2024-04-02 13:15:17 +00:00
lib/view/pages/more/feedback/feedbackDialog.dart Outdated
@@ -69,2 +69,4 @@
minLines: 4,
maxLines: 7,
onTapOutside: (PointerDownEvent event) {
FocusScope.of(context).requestFocus(FocusNode());
MineTec commented 2024-04-02 13:15:17 +00:00
Owner
Copy Link

der Methodeninhalt sollte in eine eigene Klasse/Funktion ausgelagert werden

klassenname z.B. FocusBehavoiur
statische methode z.B. textFieldTapOutside

aufruf dann mit

onTapOutside: FocusBehaviur.textFieldTapOutside

der Methodeninhalt sollte in eine eigene Klasse/Funktion ausgelagert werden klassenname z.B. FocusBehavoiur statische methode z.B. textFieldTapOutside aufruf dann mit onTapOutside: `FocusBehaviur.textFieldTapOutside`
MineTec commented 2024-04-02 13:15:37 +00:00
Owner
Copy Link

dann entsprechend alle vorkomnisse durch die methode ersetzen

dann entsprechend alle vorkomnisse durch die methode ersetzen
Pupsi marked this conversation as resolved
MineTec reviewed 2024-04-02 13:15:41 +00:00
lib/view/pages/talk/components/chatTextfield.dart Outdated
@@ -157,2 +157,4 @@
setDraft(text);
},
onTapOutside: (PointerDownEvent event) {
FocusScope.of(context).requestFocus(FocusNode());
MineTec commented 2024-04-02 13:15:41 +00:00
Owner
Copy Link

.

.
Pupsi marked this conversation as resolved
MineTec reviewed 2024-04-02 13:15:45 +00:00
lib/view/pages/timetable/customTimetableEventEditDialog.dart Outdated
@@ -68,2 +68,4 @@
border: OutlineInputBorder()
),
onTapOutside: (PointerDownEvent event) {
FocusScope.of(context).requestFocus(FocusNode());
MineTec commented 2024-04-02 13:15:45 +00:00
Owner
Copy Link

.

.
Pupsi marked this conversation as resolved
MineTec reviewed 2024-04-02 13:15:48 +00:00
lib/view/pages/timetable/customTimetableEventEditDialog.dart Outdated
@@ -79,2 +82,4 @@
border: OutlineInputBorder()
),
onTapOutside: (PointerDownEvent event) {
FocusScope.of(context).requestFocus(FocusNode());
MineTec commented 2024-04-02 13:15:48 +00:00
Owner
Copy Link

.

.
Pupsi marked this conversation as resolved
MineTec commented 2024-04-02 13:16:23 +00:00
Owner
Copy Link

Ich nehme an du hast das neue Verhalten gut durchgetestet?

Nicht das das ungewollte seiteneffekte hat :)

Ich nehme an du hast das neue Verhalten gut durchgetestet? Nicht das das ungewollte seiteneffekte hat :)
Pupsi added 1 commit 2024-04-02 14:45:51 +00:00
resolved pr comments 6450b292a7
MineTec merged commit 883db8d7ef into develop 2024-04-02 14:55:36 +00:00
MineTec deleted branch develop-unfocusTextField 2024-04-02 14:55:40 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
MineTec
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 feedback
Feedback von Nutzer
 help wanted
Need some help
 question
More information is needed
 technnical
Not user facing
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bytedream goldbaja MineTec olischma Pupsi
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarianumMobile/Client#56
Delete Branch "develop-unfocusTextField"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?