develop-turtleGame #6

Merged
Pupsi merged 32 commits from develop-turtleGame into develop 2025-10-15 20:21:27 +00:00
Collaborator
No description provided.
Pupsi added 24 commits 2025-10-15 19:05:12 +00:00
@@ -0,0 +51,4 @@
this.generatePlatform();
}
private void generatePlatform() {
Owner

eigne methode ist hier irgendwie unnötig...

eigne methode ist hier irgendwie unnötig...
Pupsi marked this conversation as resolved
@@ -0,0 +117,4 @@
protected void eat(Player p, Entity snack) {
p.playSound(Sound.sound(SoundEvent.ENTITY_GENERIC_EAT, Sound.Source.MASTER, 1f, 1f), snack.getPosition());
Material snackMaterial = this.snackBlock.registry().material();
if(snackMaterial == null) snackMaterial = Material.DIRT;
Owner

ändern zu Objects.requireNotNull() und den fallback zu Material.DIRT weg

ändern zu Objects.requireNotNull() und den fallback zu Material.DIRT weg
Pupsi marked this conversation as resolved
@@ -0,0 +184,4 @@
private void generateNewSnack() {
Entity snack = new Entity(EntityType.FALLING_BLOCK);
FallingBlockMeta meta = (FallingBlockMeta) snack.getEntityMeta();
meta.setBlock(this.snackBlock.withProperty("half", "upper"));
Owner

property doppelt sich?

property doppelt sich?
Pupsi marked this conversation as resolved
@@ -0,0 +185,4 @@
Entity snack = new Entity(EntityType.FALLING_BLOCK);
FallingBlockMeta meta = (FallingBlockMeta) snack.getEntityMeta();
meta.setBlock(this.snackBlock.withProperty("half", "upper"));
meta.setCustomName(Component.text("Snack").color(NamedTextColor.WHITE));
Owner

default color ist nicht weiß?

default color ist nicht weiß?
Pupsi marked this conversation as resolved
@@ -0,0 +193,4 @@
snack.remove();
return;
}
snack.teleport(spawnPosition);
Owner

statt teleport direkt bei setInstance als zweiter Parameter die Position übergeben

statt teleport direkt bei setInstance als zweiter Parameter die Position übergeben
Pupsi marked this conversation as resolved
@@ -0,0 +215,4 @@
bomb.remove();
return;
}
bomb.teleport(spawnPosition);
Owner

nochmal

nochmal
Pupsi marked this conversation as resolved
@@ -0,0 +219,4 @@
this.bombs.add(bomb);
}
@Nullable
Owner

@Nullable gehört vor die Rückgabe parameter private @Nullable Pos newSpawnPosition(

@Nullable gehört vor die Rückgabe parameter `private @Nullable Pos newSpawnPosition(`
Pupsi marked this conversation as resolved
@@ -0,0 +224,4 @@
return this.newSpawnPosition(entity, true);
}
@Nullable
Owner

nochmal

nochmal
Pupsi marked this conversation as resolved
@@ -0,0 +230,4 @@
int counter = 0;
boolean isInRadius, collides;
do {
if(counter > 200) {
Owner

mMn. curly braces weg

mMn. curly braces weg
Pupsi marked this conversation as resolved
@@ -0,0 +31,4 @@
public void spawnTurtle() {
this.setInstance(this.player.getInstance());
this.teleport(this.player.getPosition());
Owner

statt teleport bei setInstance übergeben

statt teleport bei setInstance übergeben
Pupsi marked this conversation as resolved
Pupsi added 2 commits 2025-10-15 19:26:07 +00:00
@@ -0,0 +45,4 @@
public void destroy() {
this.removePassenger(this.player);
this.remove();
this.kill();
Owner

kill nach remove? macht das überhaupt irgendwas?

kill nach remove? macht das überhaupt irgendwas?
Author
Collaborator

nein

nein
Pupsi marked this conversation as resolved
@@ -0,0 +76,4 @@
return;
}
this.boostChargeLevel = Math.max(0f, this.boostChargeLevel - 0.025f);
System.out.println(this.boostChargeLevel);
Owner

raus

raus
Pupsi marked this conversation as resolved
Pupsi added 1 commit 2025-10-15 19:30:16 +00:00
Pupsi added 1 commit 2025-10-15 19:33:21 +00:00
Pupsi added 1 commit 2025-10-15 19:56:53 +00:00
MineTec added 1 commit 2025-10-15 20:01:12 +00:00
Pupsi added 2 commits 2025-10-15 20:20:17 +00:00
MineTec approved these changes 2025-10-15 20:21:12 +00:00
Pupsi merged commit 50200b46ae into develop 2025-10-15 20:21:27 +00:00
Pupsi deleted branch develop-turtleGame 2025-10-15 20:21:28 +00:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MineNet/Minigames#6