develop-fairScoreboard #4

Pupsi · 2025-10-10T23:08:18Z

Pupsi commented

2025-10-10 23:08:18 +00:00

Ich hoffe es funktioniert alles...

Pupsi added 2 commits 2025-10-10 23:08:18 +00:00

added possibility for same scores in PointsWinScore e871c0bcb5

added possibility for same scores Tournament 123c01da14

MineTec reviewed 2025-10-11 00:36:07 +00:00

src/main/java/eu/mhsl/minenet/minigames/score/tournament/TournamentDisplay.java Outdated

						
				@@ -59,2 +66,3 @@

				                .toList();

				        new ChatMessage(Icon.STAR)

				                .numberedList(this.places.stream().map(player -> String.format("%s - %s Punkte", player.getUsername(), tournament.getGameScores().get(player))).toList())

				                .list(players.stream().map(player -> String.format("%s. %s - %s Punkte", this.getRankPosition(player)+1, player.getUsername(), tournament.getGameScores().get(player))).toList())

MineTec commented

2025-10-11 00:36:06 +00:00

korrekte verwendung von datentypen im format (%d)

Pupsi marked this conversation as resolved

MineTec reviewed 2025-10-11 00:48:18 +00:00

src/main/java/eu/mhsl/minenet/minigames/score/tournament/Tournament.java

						
				@@ -47,2 +47,3 @@

				        for (Set<Player> players : getPlaces()) {

				            if(count >= this.rewardConfiguration.rewardCount().size()) break;

				            itemCount.put(player.getUuid(), this.rewardConfiguration.rewardCount().get(count));

				            for(Player player : players) {

MineTec commented

2025-10-11 00:48:18 +00:00

warum kein lambda foreach?

Pupsi commented

2025-10-11 09:35:28 +00:00

Weil count keine effectively final temp variable (oder so) ist

Pupsi marked this conversation as resolved

Pupsi added 1 commit 2025-10-11 09:36:08 +00:00

solved pr comment ae59482d7c

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin develop-fairScoreboard:develop-fairScoreboard

git checkout develop-fairScoreboard

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MineNet/Minigames#4