develop-customTimetableEventColors #45

Closed
Pupsi wants to merge 0 commits from develop-customTimetableEventColors into develop
Member
No description provided.
Pupsi added 2 commits 2024-03-17 16:10:15 +00:00
@@ -4,6 +4,7 @@ import 'dart:developer';
import 'package:flutter/material.dart';
import 'package:jiffy/jiffy.dart';
import 'package:marianum_mobile/extensions/dateTime.dart';
import 'package:marianum_mobile/view/pages/timetable/custonTimetableColors.dart';
Owner

bitte relative imports für nicht-extensions benutzen

bitte relative imports für nicht-extensions benutzen
Pupsi marked this conversation as resolved
@@ -34,1 +35,4 @@
late String _recurringRule = widget.existingEvent?.rrule ?? "";
late CustomTimetableColors _customTimetableColor = CustomTimetableColors.values.firstWhere(
(element) => element.name == widget.existingEvent?.color,
orElse: () => CustomTimetableColors.orange
Owner

es macht ggf. sinn die Standartfarbe als konstante auszzulagern, damit die standartfarbe bei bedarf einfach geändert werden kann

es macht ggf. sinn die Standartfarbe als konstante auszzulagern, damit die standartfarbe bei bedarf einfach geändert werden kann
Pupsi marked this conversation as resolved
@@ -0,0 +1,39 @@
import 'package:flutter/material.dart';
import 'package:marianum_mobile/theming/darkAppTheme.dart';
enum CustomTimetableColors{
Owner

Leerzeichen nach Klassen-Namen

Leerzeichen nach Klassen-Namen
Pupsi marked this conversation as resolved
@@ -0,0 +26,4 @@
}
}
static Color getColorFromString(String color){
Owner

Leerzeichen nach Klassen-Namen

Leerzeichen nach Klassen-Namen
Pupsi marked this conversation as resolved
@@ -3,6 +3,7 @@ import 'dart:async';
import 'package:flutter/material.dart';
import 'package:marianum_mobile/extensions/dateTime.dart';
import 'package:marianum_mobile/view/pages/timetable/custonTimetableColors.dart';
Owner

relative imports

relative imports
Pupsi marked this conversation as resolved
@@ -290,3 +291,3 @@
subject: customEvent.title,
recurrenceRule: customEvent.rrule,
color: Colors.deepOrange.shade800,
color: TimetableColors.getColorFromString(customEvent.color ?? CustomTimetableColors.orange.name),
Owner

verwendung der konstante für den standartwert

verwendung der konstante für den standartwert
Pupsi marked this conversation as resolved
Pupsi added 1 commit 2024-03-17 16:38:56 +00:00
Owner

merged via 010e2785fe

merged via 010e2785fe37b1848b61db05eed656abf4f7440b
MineTec closed this pull request 2024-03-17 16:42:42 +00:00
MineTec deleted branch develop-customTimetableEventColors 2024-03-17 16:43:18 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarianumMobile/Client#45