MarianumMobile/Client
5
1
Fork 0
Code Issues 33 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

develop-customTimetableEventColors #45

Closed
Pupsi wants to merge 0 commits from develop-customTimetableEventColors into develop
pull from: develop-customTimetableEventColors
merge into: MarianumMobile:develop
Conversation 7 Commits - Files Changed -
Pupsi commented 2024-03-17 16:10:15 +00:00
Member
Copy Link
No description provided.
Pupsi added 2 commits 2024-03-17 16:10:15 +00:00
option to change custom timetable event colors a2f1ccae7b
added fallback option for non existing colors e40760a07a
MineTec reviewed 2024-03-17 16:23:35 +00:00
lib/view/pages/timetable/customTimetableEventEditDialog.dart Outdated
@@ -4,6 +4,7 @@ import 'dart:developer';
import 'package:flutter/material.dart';
import 'package:jiffy/jiffy.dart';
import 'package:marianum_mobile/extensions/dateTime.dart';
import 'package:marianum_mobile/view/pages/timetable/custonTimetableColors.dart';
MineTec commented 2024-03-17 16:23:35 +00:00
Owner
Copy Link

bitte relative imports für nicht-extensions benutzen

bitte relative imports für nicht-extensions benutzen
Pupsi marked this conversation as resolved
MineTec reviewed 2024-03-17 16:25:30 +00:00
lib/view/pages/timetable/customTimetableEventEditDialog.dart Outdated
@@ -34,1 +35,4 @@
late String _recurringRule = widget.existingEvent?.rrule ?? "";
late CustomTimetableColors _customTimetableColor = CustomTimetableColors.values.firstWhere(
(element) => element.name == widget.existingEvent?.color,
orElse: () => CustomTimetableColors.orange
MineTec commented 2024-03-17 16:25:30 +00:00
Owner
Copy Link

es macht ggf. sinn die Standartfarbe als konstante auszzulagern, damit die standartfarbe bei bedarf einfach geändert werden kann

es macht ggf. sinn die Standartfarbe als konstante auszzulagern, damit die standartfarbe bei bedarf einfach geändert werden kann
Pupsi marked this conversation as resolved
MineTec reviewed 2024-03-17 16:25:57 +00:00
lib/view/pages/timetable/custonTimetableColors.dart Outdated
@@ -0,0 +1,39 @@
import 'package:flutter/material.dart';
import 'package:marianum_mobile/theming/darkAppTheme.dart';
enum CustomTimetableColors{
MineTec commented 2024-03-17 16:25:57 +00:00
Owner
Copy Link

Leerzeichen nach Klassen-Namen

Leerzeichen nach Klassen-Namen
Pupsi marked this conversation as resolved
MineTec reviewed 2024-03-17 16:26:05 +00:00
lib/view/pages/timetable/custonTimetableColors.dart Outdated
@@ -0,0 +26,4 @@
}
}
static Color getColorFromString(String color){
MineTec commented 2024-03-17 16:26:05 +00:00
Owner
Copy Link

Leerzeichen nach Klassen-Namen

Leerzeichen nach Klassen-Namen
Pupsi marked this conversation as resolved
MineTec reviewed 2024-03-17 16:26:30 +00:00
lib/view/pages/timetable/timetable.dart Outdated
@@ -3,6 +3,7 @@ import 'dart:async';
import 'package:flutter/material.dart';
import 'package:marianum_mobile/extensions/dateTime.dart';
import 'package:marianum_mobile/view/pages/timetable/custonTimetableColors.dart';
MineTec commented 2024-03-17 16:26:30 +00:00
Owner
Copy Link

relative imports

relative imports
Pupsi marked this conversation as resolved
MineTec reviewed 2024-03-17 16:26:54 +00:00
lib/view/pages/timetable/timetable.dart Outdated
@@ -290,3 +291,3 @@
subject: customEvent.title,
recurrenceRule: customEvent.rrule,
color: Colors.deepOrange.shade800,
color: TimetableColors.getColorFromString(customEvent.color ?? CustomTimetableColors.orange.name),
MineTec commented 2024-03-17 16:26:54 +00:00
Owner
Copy Link

verwendung der konstante für den standartwert

verwendung der konstante für den standartwert
Pupsi marked this conversation as resolved
Pupsi added 1 commit 2024-03-17 16:38:56 +00:00
resolved pr comments 90154880d0
MineTec commented 2024-03-17 16:42:42 +00:00
Owner
Copy Link

merged via 010e2785fe

merged via 010e2785fe37b1848b61db05eed656abf4f7440b
MineTec closed this pull request 2024-03-17 16:42:42 +00:00
MineTec deleted branch develop-customTimetableEventColors 2024-03-17 16:43:18 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
MineTec
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 feedback
Feedback von Nutzer
 help wanted
Need some help
 question
More information is needed
 technnical
Not user facing
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bytedream goldbaja MineTec olischma Pupsi
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarianumMobile/Client#45
Delete Branch "develop-customTimetableEventColors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?