MineNet/Minigames
6
0 Fork 0
Code Issues Pull Requests 1 Packages Projects Releases 1 Wiki Activity

Bug fixing #17

Merged
MineTec merged 3 commits from bugFixing into develop 2026-10-28 21:13:04 +00:00
Conversation 3 Commits 3 Files Changed 2
+6 -5
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9d779a4879 - Show all commits
src/main/java/eu/mhsl/minenet/minigames/instance/game/stateless/types/highGround/HighGround.java
+6 -5
View File
@@ -9,6 +9,7 @@ import io.github.togar2.pvp.events.FinalAttackEvent;
import io.github.togar2.pvp.events.PrepareAttackEvent; import io.github.togar2.pvp.events.PrepareAttackEvent;
import io.github.togar2.pvp.feature.CombatFeatures; import io.github.togar2.pvp.feature.CombatFeatures;
import io.github.togar2.pvp.feature.knockback.KnockbackSettings; import io.github.togar2.pvp.feature.knockback.KnockbackSettings;
import net.minestom.server.ServerFlag;
import net.minestom.server.coordinate.Pos; import net.minestom.server.coordinate.Pos;
import net.minestom.server.entity.Player; import net.minestom.server.entity.Player;
import net.minestom.server.event.instance.InstanceTickEvent; import net.minestom.server.event.instance.InstanceTickEvent;
@@ -52,14 +53,14 @@ class HighGround extends StatelessGame {
this.eventNode().addListener( this.eventNode().addListener(
EntityKnockbackEvent.class, EntityKnockbackEvent.class,
entityKnockbackEvent -> { entityKnockbackEvent -> {
MineTec marked this conversation as resolved
MineTec commented 2026-10-28 11:59:12 +00:00
Review
Copy link
Copy source

der check behandelt das Symptom, nicht die Ursache
Der check sollte nicht nötig sein.

der check behandelt das Symptom, nicht die Ursache Der check sollte nicht nötig sein.
if(entityKnockbackEvent.getEntity().getVelocity().y() > 4) { entityKnockbackEvent.setCancelled(true); return; } double tps = ServerFlag.SERVER_TICKS_PER_SECOND;
entityKnockbackEvent.setSettings( entityKnockbackEvent.setSettings(
KnockbackSettings.builder() KnockbackSettings.builder()
.horizontal(1.1) .horizontal(1.1)
.vertical(0) .vertical(KnockbackSettings.DEFAULT.vertical() / tps)
.verticalLimit(0) .verticalLimit(KnockbackSettings.DEFAULT.verticalLimit() / tps)
.extraHorizontal(0.5) .extraHorizontal(KnockbackSettings.DEFAULT.extraHorizontal() / tps)
.extraVertical(0) .extraVertical(KnockbackSettings.DEFAULT.extraVertical() / tps)
.build() .build()
); );
} }