MineNet/Minigames
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

added color jump #12

Merged
jannis merged 5 commits from develop-colorjump into develop 2026-02-10 20:24:18 +00:00
Conversation 2 Commits 5 Files Changed 4 +6 -7
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2808393c23 - Show all commits

9
src/main/java/eu/mhsl/minenet/minigames/instance/game/stateless/types/colorJump/ColorJump.java
View File

@@ -70,7 +70,7 @@ public class ColorJump extends StatelessGame {
this.destroyAllExcept(this.currentBlock); this.destroyAllExcept(this.currentBlock);
scheduler.scheduleTask(() -> { scheduler.scheduleTask(() -> {
this.onStart(); this.nextRound();
jannis marked this conversation as resolved Outdated
Pupsi commented 2026-02-10 19:58:48 +00:00
Outdated
Review
Copy Link

this.nextRound()

this.nextRound()
return stop; return stop;
}, TaskSchedule.seconds(3)); }, TaskSchedule.seconds(3));
return stop; return stop;
@@ -130,12 +130,11 @@ public class ColorJump extends StatelessGame {
protected void onPlayerMove(@NotNull PlayerMoveEvent playerMoveEvent) { protected void onPlayerMove(@NotNull PlayerMoveEvent playerMoveEvent) {
var player = playerMoveEvent.getPlayer(); var player = playerMoveEvent.getPlayer();
if(this.isBeforeBeginning && playerMoveEvent.getNewPosition().y() < 29) if(playerMoveEvent.getNewPosition().y() >= 29)
jannis marked this conversation as resolved Outdated
Pupsi commented 2026-02-10 20:01:22 +00:00
Outdated
Review
Copy Link

early return:
if(playerMoveEvent.getNewPosition().y() >= 29) return;
player.teleport(this.getSpawn());
if(this.isRunning) ......

early return: if(playerMoveEvent.getNewPosition().y() >= 29) return; player.teleport(this.getSpawn()); if(this.isRunning) ......
return;
player.teleport(this.getSpawn()); player.teleport(this.getSpawn());
if(this.isRunning) {
if(this.isRunning && playerMoveEvent.getNewPosition().y() < 29) {
this.getScore().insertResult(player); this.getScore().insertResult(player);
player.teleport(this.getSpawn());
player.setGameMode(GameMode.SPECTATOR); player.setGameMode(GameMode.SPECTATOR);
} }
} }