Files
Client/test/api/autocomplete_response_test.dart
T
MineTecandClaude Fable 5.1 279b973e89 hardened API decoding against server fields the models did not expect
The Talk room list crashed for a new account because the server omits
lastMessage for rooms without a visible message and the model required it.
Beyond that single field, a review of the Talk models against the OpenAPI
spec of the installed version (23.0.8) found the same crash class in several
places: closed enums over open server values (inCall bitmask, rich-object
types, actor and message types), a deleted parent sent as {id, deleted},
and the autocomplete status arriving as an object.

- json_serializable `checked: true`: decode errors now name class and field
- lists (rooms, messages, participants, autocomplete) decode per entry;
  a malformed entry is skipped and reported via ClientErrorReporter
- unknownEnumValue fallbacks for all response enums of Talk and breakers
- lastMessage nullable; inCall as bitmask; deleted parent placeholder;
  autocomplete status object/string; fixed shareWithDisplayNameUnique key
- GetRoomParams no longer sends null query parameters

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HrepDTL4qDe35TuS29sLW3
2026-09-29 16:35:41 +02:00

33 lines
1.0 KiB
Dart

import 'package:flutter_test/flutter_test.dart';
import 'package:marianum_mobile/api/json_lenient.dart';
import 'package:marianum_mobile/api/marianumcloud/autocomplete/autocomplete_response.dart';
void main() {
test('accepts the status as object, string or empty', () {
final response = AutocompleteResponse.fromJson({
'data': [
{
'id': 'a',
'label': 'A',
'status': {'status': 'online', 'message': null},
},
{'id': 'b', 'label': 'B', 'status': ''},
{'id': 'c', 'label': 'C', 'status': 'dnd'},
],
});
expect(response.data.map((e) => e.status), ['online', null, 'dnd']);
expect(drainDecodeWarnings(), isEmpty);
});
test('skips an entry without id instead of failing the search', () {
final response = AutocompleteResponse.fromJson({
'data': [
{'label': 'no id'},
{'id': 'b', 'label': 'B'},
],
});
expect(response.data.single.id, 'b');
expect(drainDecodeWarnings().single, contains('"id"'));
});
}