resolved pr comments

This commit is contained in:
Lars Neuhaus 2024-04-02 16:45:43 +02:00
parent 21411e1517
commit 6450b292a7
6 changed files with 21 additions and 42 deletions

View File

@ -14,6 +14,7 @@ import '../../../../api/mhsl/server/feedback/addFeedbackParams.dart';
import '../../../../model/accountData.dart'; import '../../../../model/accountData.dart';
import '../../../../storage/base/settingsProvider.dart'; import '../../../../storage/base/settingsProvider.dart';
import '../../../../widget/filePick.dart'; import '../../../../widget/filePick.dart';
import '../../../../widget/focusBehaviour.dart';
import '../../../../widget/infoDialog.dart'; import '../../../../widget/infoDialog.dart';
class FeedbackDialog extends StatefulWidget { class FeedbackDialog extends StatefulWidget {
@ -68,9 +69,7 @@ class _FeedbackDialogState extends State<FeedbackDialog> {
), ),
minLines: 4, minLines: 4,
maxLines: 7, maxLines: 7,
onTapOutside: (PointerDownEvent event) { onTapOutside: (PointerDownEvent event) => FocusBehaviour.textFieldTapOutside(context),
FocusScope.of(context).requestFocus(FocusNode());
},
), ),
), ),
const SizedBox(height: 10), const SizedBox(height: 10),

View File

@ -110,13 +110,13 @@ class _ChatViewState extends State<ChatView> {
), ),
body: Container( body: Container(
decoration: BoxDecoration( decoration: BoxDecoration(
image: DecorationImage( image: DecorationImage(
image: const AssetImage('assets/background/chat.png'), image: const AssetImage('assets/background/chat.png'),
scale: 1.5, scale: 1.5,
opacity: 1, opacity: 1,
repeat: ImageRepeat.repeat, repeat: ImageRepeat.repeat,
invertColors: AppTheme.isDarkMode(context) invertColors: AppTheme.isDarkMode(context),
) )
), ),
child: data.primaryLoading() ? const LoadingSpinner() : Column( child: data.primaryLoading() ? const LoadingSpinner() : Column(
children: [ children: [

View File

@ -14,6 +14,7 @@ import '../../../../api/marianumcloud/webdav/webdavApi.dart';
import '../../../../model/chatList/chatProps.dart'; import '../../../../model/chatList/chatProps.dart';
import '../../../../storage/base/settingsProvider.dart'; import '../../../../storage/base/settingsProvider.dart';
import '../../../../widget/filePick.dart'; import '../../../../widget/filePick.dart';
import '../../../../widget/focusBehaviour.dart';
import '../../files/fileUploadDialog.dart'; import '../../files/fileUploadDialog.dart';
class ChatTextfield extends StatefulWidget { class ChatTextfield extends StatefulWidget {
@ -156,9 +157,7 @@ class _ChatTextfieldState extends State<ChatTextfield> {
} }
setDraft(text); setDraft(text);
}, },
onTapOutside: (PointerDownEvent event) { onTapOutside: (PointerDownEvent event) => FocusBehaviour.textFieldTapOutside(context),
FocusScope.of(context).requestFocus(FocusNode());
},
), ),
), ),
const SizedBox(width: 15), const SizedBox(width: 15),

View File

@ -15,6 +15,7 @@ import '../../../api/mhsl/customTimetableEvent/update/updateCustomTimetableEvent
import '../../../api/mhsl/customTimetableEvent/update/updateCustomTimetableEventParams.dart'; import '../../../api/mhsl/customTimetableEvent/update/updateCustomTimetableEventParams.dart';
import '../../../model/accountData.dart'; import '../../../model/accountData.dart';
import '../../../model/timetable/timetableProps.dart'; import '../../../model/timetable/timetableProps.dart';
import '../../../widget/focusBehaviour.dart';
import '../../../widget/infoDialog.dart'; import '../../../widget/infoDialog.dart';
import 'customTimetableColors.dart'; import 'customTimetableColors.dart';
@ -67,9 +68,7 @@ class _AddCustomTimetableEventDialogState extends State<CustomTimetableEventEdit
labelText: 'Terminname', labelText: 'Terminname',
border: OutlineInputBorder() border: OutlineInputBorder()
), ),
onTapOutside: (PointerDownEvent event) { onTapOutside: (PointerDownEvent event) => FocusBehaviour.textFieldTapOutside(context),
FocusScope.of(context).requestFocus(FocusNode());
},
), ),
), ),
ListTile( ListTile(
@ -81,9 +80,7 @@ class _AddCustomTimetableEventDialogState extends State<CustomTimetableEventEdit
labelText: 'Beschreibung', labelText: 'Beschreibung',
border: OutlineInputBorder() border: OutlineInputBorder()
), ),
onTapOutside: (PointerDownEvent event) { onTapOutside: (PointerDownEvent event) => FocusBehaviour.textFieldTapOutside(context),
FocusScope.of(context).requestFocus(FocusNode());
},
), ),
), ),
const Divider(), const Divider(),

View File

@ -0,0 +1,7 @@
import 'package:flutter/cupertino.dart';
class FocusBehaviour {
static void textFieldTapOutside(BuildContext context) {
FocusScope.of(context).requestFocus(FocusNode());
}
}

View File

@ -1,23 +0,0 @@
import 'package:flutter/material.dart';
class QuickMenu {
static void quickMenu(BuildContext context, BuildContext widgetContext, List<PopupMenuItem<dynamic>> items) {
final RenderBox overlay = Overlay.of(context).context.findRenderObject() as RenderBox;
final RenderBox widgetRenderBox = widgetContext.findRenderObject() as RenderBox;
final Offset position = widgetRenderBox.localToGlobal(Offset.zero);
showMenu(
context: context,
position: RelativeRect.fromRect(
Rect.fromPoints(
position,
position.translate(0, 0),
),
Offset.zero & overlay.size,
),
items: items,
);
}
}