improved performance and battery usage on older devices
This commit is contained in:
@@ -59,6 +59,12 @@ class ChatBloc
|
||||
@override
|
||||
ChatState fromStorage(Map<String, dynamic> json) => ChatState.fromJson(json);
|
||||
|
||||
// Loading-older and reply-reference flips must not re-persist up to 500
|
||||
// messages; GetChatResponse has no `==`, so it compares by identity here.
|
||||
@override
|
||||
Object? persistenceKey(ChatState data) =>
|
||||
(data.currentToken, data.chatResponse, data.hasMoreOld);
|
||||
|
||||
@override
|
||||
Map<String, dynamic>? toStorage(ChatState state) {
|
||||
final response = state.chatResponse;
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import 'dart:async';
|
||||
import 'dart:convert';
|
||||
import 'dart:developer';
|
||||
|
||||
import 'package:flutter_app_badge/flutter_app_badge.dart';
|
||||
@@ -6,6 +7,7 @@ import 'package:flutter_app_badge/flutter_app_badge.dart';
|
||||
import '../../../../../api/marianumcloud/talk/actions/talk_actions.dart';
|
||||
import '../../../../../api/marianumcloud/talk/chat/get_chat_response.dart';
|
||||
import '../../../../../api/marianumcloud/talk/room/get_room_response.dart';
|
||||
import '../../../../../utils/session_single_flight.dart';
|
||||
import '../../../infrastructure/utility_widgets/loadable_hydrated_bloc/loadable_hydrated_bloc.dart';
|
||||
import '../../../infrastructure/utility_widgets/loadable_hydrated_bloc/loadable_hydrated_bloc_event.dart';
|
||||
import '../repository/chat_list_repository.dart';
|
||||
@@ -74,13 +76,32 @@ class ChatListBloc
|
||||
renew: renew,
|
||||
onError: (e) => capturedError = e,
|
||||
);
|
||||
_lastRoomsJson = null;
|
||||
add(DataGathered((s) => s.copyWith(rooms: rooms)));
|
||||
_updateAppBadge(rooms);
|
||||
|
||||
if (capturedError != null) throw capturedError!;
|
||||
}
|
||||
|
||||
Future<void> refresh({bool renew = true, bool silent = false}) async {
|
||||
final SessionSingleFlight _refreshFlight = SessionSingleFlight();
|
||||
|
||||
/// Concurrent callers (tab switch, poll, push, resume) join the running
|
||||
/// refresh instead of each fetching and re-emitting the full room list.
|
||||
Future<void> refresh({bool renew = true, bool silent = false}) =>
|
||||
_refreshFlight.run(() => _refresh(renew: renew, silent: silent));
|
||||
|
||||
/// Skips the refresh when the list was fetched within [maxAge].
|
||||
Future<void> refreshIfOlderThan(Duration maxAge) {
|
||||
final lastFetch = state.lastFetch;
|
||||
if (lastFetch != null &&
|
||||
DateTime.now().millisecondsSinceEpoch - lastFetch <
|
||||
maxAge.inMilliseconds) {
|
||||
return Future.value();
|
||||
}
|
||||
return refresh();
|
||||
}
|
||||
|
||||
Future<void> _refresh({required bool renew, required bool silent}) async {
|
||||
if (!silent) add(RefetchStarted<ChatListState>());
|
||||
Object? capturedError;
|
||||
try {
|
||||
@@ -88,6 +109,11 @@ class ChatListBloc
|
||||
renew: renew,
|
||||
onError: (e) => capturedError = e,
|
||||
);
|
||||
if (silent) {
|
||||
if (_isUnchanged(rooms)) return;
|
||||
} else {
|
||||
_lastRoomsJson = null;
|
||||
}
|
||||
add(DataGathered((s) => s.copyWith(rooms: rooms)));
|
||||
_updateAppBadge(rooms);
|
||||
} catch (e) {
|
||||
@@ -96,6 +122,23 @@ class ChatListBloc
|
||||
if (capturedError != null) addLoadingError(capturedError!);
|
||||
}
|
||||
|
||||
// Encoded room data of the last applied poll result; response headers are
|
||||
// left out because they differ on every request.
|
||||
String? _lastRoomsJson;
|
||||
|
||||
/// A background poll that returns the same rooms would otherwise rebuild the
|
||||
/// list and re-persist the whole state every 15 s.
|
||||
bool _isUnchanged(GetRoomResponse rooms) {
|
||||
final encoded = jsonEncode(rooms.data);
|
||||
final unchanged =
|
||||
encoded == _lastRoomsJson &&
|
||||
innerState?.rooms != null &&
|
||||
state.error == null &&
|
||||
!state.isLoading;
|
||||
_lastRoomsJson = encoded;
|
||||
return unchanged;
|
||||
}
|
||||
|
||||
/// Creates (or resolves) a 1:1 chat and returns its room token, or null in
|
||||
/// demo mode. Refreshes the list so the room shows up.
|
||||
Future<String?> createDirectChat(String invite) async {
|
||||
@@ -171,6 +214,7 @@ class ChatListBloc
|
||||
}).toSet();
|
||||
if (!changed) return;
|
||||
final newRooms = GetRoomResponse(updated)..headers = rooms.headers;
|
||||
_lastRoomsJson = null;
|
||||
add(Emit((s) => s.copyWith(rooms: newRooms)));
|
||||
_updateAppBadge(newRooms);
|
||||
}
|
||||
|
||||
@@ -142,12 +142,11 @@ class ForeignTimetableBloc
|
||||
|
||||
add(
|
||||
Emit(
|
||||
(s) => s.copyWith(
|
||||
(s) => s.withReferenceData(
|
||||
rooms: rooms,
|
||||
subjects: subjects,
|
||||
schoolHolidays: schoolHolidays,
|
||||
schoolyear: schoolyear,
|
||||
dataVersion: s.dataVersion + 1,
|
||||
),
|
||||
),
|
||||
);
|
||||
@@ -157,11 +156,7 @@ class ForeignTimetableBloc
|
||||
|
||||
try {
|
||||
final timegrid = await repo.data.getTimegrid();
|
||||
add(
|
||||
Emit(
|
||||
(s) => s.copyWith(timegrid: timegrid, dataVersion: s.dataVersion + 1),
|
||||
),
|
||||
);
|
||||
add(Emit((s) => s.withReferenceData(timegrid: timegrid)));
|
||||
} catch (_) {
|
||||
// Timegrid load failure falls back to a hardcoded schedule in the UI.
|
||||
}
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
import 'package:dio/dio.dart';
|
||||
import 'package:enough_icalendar/enough_icalendar.dart';
|
||||
import 'package:flutter/foundation.dart';
|
||||
|
||||
import '../bloc/marianum_dates_state.dart';
|
||||
|
||||
@@ -19,6 +20,12 @@ class MarianumDatesGetEvents {
|
||||
final body = response.data;
|
||||
if (body == null || body.isEmpty) return [];
|
||||
|
||||
// The public feed holds hundreds of events back to 1981; parsing it on
|
||||
// the UI isolate froze the page for a noticeable moment on every open.
|
||||
return compute(parseEvents, body);
|
||||
}
|
||||
|
||||
static List<MarianumDate> parseEvents(String body) {
|
||||
final root = VComponent.parse(body);
|
||||
final calendar = root is VCalendar ? root : null;
|
||||
final source = calendar?.children ?? root.children;
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import 'dart:async';
|
||||
import 'dart:developer';
|
||||
|
||||
import 'package:collection/collection.dart';
|
||||
import 'package:hydrated_bloc/hydrated_bloc.dart';
|
||||
|
||||
import '../../../../../storage/settings.dart';
|
||||
@@ -10,6 +11,8 @@ import '../../../../../view/pages/settings/data/default_settings.dart';
|
||||
class SettingsCubit extends HydratedCubit<Settings> {
|
||||
static const _debounceTag = 'settings_persist';
|
||||
bool _emitScheduled = false;
|
||||
Map<String, dynamic>? _lastEmittedJson;
|
||||
Timer? _silentSave;
|
||||
|
||||
SettingsCubit() : super(DefaultSettings.get());
|
||||
|
||||
@@ -34,21 +37,53 @@ class SettingsCubit extends HydratedCubit<Settings> {
|
||||
return state;
|
||||
}
|
||||
|
||||
/// Persists in-place mutations without notifying listeners. For high-frequency
|
||||
/// writes nobody renders live (chat drafts per keystroke): a regular write
|
||||
/// would rebuild the app root and every settings watcher on each change.
|
||||
void saveSilently() {
|
||||
_silentSave?.cancel();
|
||||
_silentSave = Timer(const Duration(milliseconds: 800), flushSilentSave);
|
||||
}
|
||||
|
||||
/// Writes a pending [saveSilently] right away (e.g. when the app pauses).
|
||||
void flushSilentSave() {
|
||||
if (_silentSave == null) return;
|
||||
_silentSave!.cancel();
|
||||
_silentSave = null;
|
||||
HydratedBloc.storage.write(storageToken, state.toJson());
|
||||
}
|
||||
|
||||
void _emitFreshInstance() {
|
||||
try {
|
||||
emit(Settings.fromJson(state.toJson()));
|
||||
final json = state.toJson();
|
||||
// The debounced emit usually follows the microtask emit with identical
|
||||
// content; skip it instead of rebuilding every listener a second time.
|
||||
if (const DeepCollectionEquality().equals(json, _lastEmittedJson)) {
|
||||
return;
|
||||
}
|
||||
_lastEmittedJson = json;
|
||||
emit(Settings.fromJson(json));
|
||||
} catch (e) {
|
||||
log('Failed to refresh settings state: $e');
|
||||
}
|
||||
}
|
||||
|
||||
Future<void> reset() async {
|
||||
_silentSave?.cancel();
|
||||
_silentSave = null;
|
||||
_lastEmittedJson = null;
|
||||
emit(DefaultSettings.get());
|
||||
}
|
||||
|
||||
// Modules missing from a stale persisted moduleOrder are handled at read
|
||||
// time by AppModule.effectiveModuleOrder (inserted at their default
|
||||
// position) — no healing on hydration needed.
|
||||
@override
|
||||
Future<void> close() {
|
||||
flushSilentSave();
|
||||
return super.close();
|
||||
}
|
||||
|
||||
@override
|
||||
Settings fromJson(Map<String, dynamic> json) {
|
||||
try {
|
||||
|
||||
@@ -1,3 +1,8 @@
|
||||
import 'dart:async';
|
||||
|
||||
import 'package:hydrated_bloc/hydrated_bloc.dart';
|
||||
import 'package:shared_preferences/shared_preferences.dart';
|
||||
|
||||
import '../../../../../api/errors/ticker_content_unavailable_exception.dart';
|
||||
import '../../../../../api/marianumconnect/queries/get_ticker_page/get_ticker_page_response.dart';
|
||||
import '../../../infrastructure/utility_widgets/loadable_hydrated_bloc/loadable_hydrated_bloc.dart';
|
||||
@@ -17,7 +22,35 @@ class TickerPageBloc
|
||||
> {
|
||||
final String slug;
|
||||
|
||||
TickerPageBloc(this.slug);
|
||||
TickerPageBloc(this.slug) {
|
||||
unawaited(_rememberSlug());
|
||||
}
|
||||
|
||||
static const _recentSlugsKey = 'tickerPageRecentSlugs';
|
||||
static const _keepPages = 50;
|
||||
|
||||
/// Every page ever opened used to stay in the hydrated box forever — and
|
||||
/// the whole box is decoded before the first frame on each cold start.
|
||||
/// The most recently opened pages (far more than a normal reader revisits)
|
||||
/// keep their offline copy; only long-forgotten ones are dropped.
|
||||
Future<void> _rememberSlug() async {
|
||||
try {
|
||||
final prefs = await SharedPreferences.getInstance();
|
||||
final recent = prefs.getStringList(_recentSlugsKey) ?? <String>[];
|
||||
recent
|
||||
..remove(slug)
|
||||
..insert(0, slug);
|
||||
for (final evicted in recent.skip(_keepPages)) {
|
||||
await HydratedBloc.storage.delete('$storagePrefix$evicted');
|
||||
}
|
||||
await prefs.setStringList(
|
||||
_recentSlugsKey,
|
||||
recent.take(_keepPages).toList(),
|
||||
);
|
||||
} on Object {
|
||||
// Best effort: a failed cleanup only leaves an extra offline copy.
|
||||
}
|
||||
}
|
||||
|
||||
@override
|
||||
String get id => slug;
|
||||
|
||||
@@ -133,11 +133,7 @@ class TimetableBloc
|
||||
|
||||
Future<void> _refreshSubjects() async {
|
||||
final subjects = await repo.data.getSubjects(renew: true);
|
||||
add(
|
||||
DataGathered(
|
||||
(s) => s.copyWith(subjects: subjects, dataVersion: s.dataVersion + 1),
|
||||
),
|
||||
);
|
||||
add(DataGathered((s) => s.withReferenceData(subjects: subjects)));
|
||||
}
|
||||
|
||||
Future<void> _loadCurrentWeek(
|
||||
@@ -177,12 +173,11 @@ class TimetableBloc
|
||||
|
||||
add(
|
||||
Emit(
|
||||
(s) => s.copyWith(
|
||||
(s) => s.withReferenceData(
|
||||
rooms: rooms,
|
||||
subjects: subjects,
|
||||
schoolHolidays: schoolHolidays,
|
||||
schoolyear: schoolyear,
|
||||
dataVersion: s.dataVersion + 1,
|
||||
),
|
||||
),
|
||||
);
|
||||
@@ -192,11 +187,7 @@ class TimetableBloc
|
||||
|
||||
try {
|
||||
final timegrid = await repo.data.getTimegrid(renew: renew);
|
||||
add(
|
||||
Emit(
|
||||
(s) => s.copyWith(timegrid: timegrid, dataVersion: s.dataVersion + 1),
|
||||
),
|
||||
);
|
||||
add(Emit((s) => s.withReferenceData(timegrid: timegrid)));
|
||||
} catch (_) {
|
||||
// Timegrid load failure falls back to a hardcoded schedule in the UI layer.
|
||||
}
|
||||
@@ -212,12 +203,7 @@ class TimetableBloc
|
||||
renew: renew,
|
||||
onError: onError,
|
||||
);
|
||||
add(
|
||||
Emit(
|
||||
(s) =>
|
||||
s.copyWith(customEvents: events, dataVersion: s.dataVersion + 1),
|
||||
),
|
||||
);
|
||||
add(Emit((s) => s.withReferenceData(customEvents: events)));
|
||||
} catch (e) {
|
||||
onError?.call(e);
|
||||
}
|
||||
@@ -225,11 +211,7 @@ class TimetableBloc
|
||||
|
||||
Future<void> _refreshCustomEvents() async {
|
||||
final events = await repo.data.getCustomEvents(renew: true);
|
||||
add(
|
||||
DataGathered(
|
||||
(s) => s.copyWith(customEvents: events, dataVersion: s.dataVersion + 1),
|
||||
),
|
||||
);
|
||||
add(DataGathered((s) => s.withReferenceData(customEvents: events)));
|
||||
}
|
||||
|
||||
void _prefetchAdjacentWeeks(DateTime start, DateTime end) {
|
||||
|
||||
@@ -7,6 +7,7 @@ import '../../../../../api/marianumconnect/queries/timetable_get_subjects/timeta
|
||||
import '../../../../../api/marianumconnect/queries/timetable_get_timegrid/timetable_get_timegrid_response.dart';
|
||||
import '../../../../../api/marianumconnect/queries/timetable_get_week/timetable_get_week_response.dart';
|
||||
import '../../../../../api/mhsl/custom_timetable_event/get/get_custom_timetable_event_response.dart';
|
||||
import '../../../../../utils/json_equality.dart';
|
||||
import 'week_cache.dart';
|
||||
|
||||
part 'timetable_state.freezed.dart';
|
||||
@@ -58,6 +59,45 @@ abstract class TimetableState with _$TimetableState {
|
||||
return copyWith(weekCache: updated, dataVersion: dataVersion + 1);
|
||||
}
|
||||
|
||||
/// Applies freshly loaded reference data. Values whose content equals the
|
||||
/// current one keep the old instance, and when nothing changed at all this
|
||||
/// returns `this` — every `dataVersion` bump and new identity makes the
|
||||
/// calendar rebuild all appointments and break regions.
|
||||
TimetableState withReferenceData({
|
||||
TimetableGetRoomsResponse? rooms,
|
||||
TimetableGetSubjectsResponse? subjects,
|
||||
TimetableGetHolidaysResponse? schoolHolidays,
|
||||
TimetableGetSchoolyearResponse? schoolyear,
|
||||
TimetableGetTimegridResponse? timegrid,
|
||||
GetCustomTimetableEventResponse? customEvents,
|
||||
}) {
|
||||
T? changed<T>(T? next, T? current) =>
|
||||
next == null || sameJson(next, current) ? null : next;
|
||||
final newRooms = changed(rooms, this.rooms);
|
||||
final newSubjects = changed(subjects, this.subjects);
|
||||
final newHolidays = changed(schoolHolidays, this.schoolHolidays);
|
||||
final newSchoolyear = changed(schoolyear, this.schoolyear);
|
||||
final newTimegrid = changed(timegrid, this.timegrid);
|
||||
final newCustomEvents = changed(customEvents, this.customEvents);
|
||||
if (newRooms == null &&
|
||||
newSubjects == null &&
|
||||
newHolidays == null &&
|
||||
newSchoolyear == null &&
|
||||
newTimegrid == null &&
|
||||
newCustomEvents == null) {
|
||||
return this;
|
||||
}
|
||||
return copyWith(
|
||||
rooms: newRooms ?? this.rooms,
|
||||
subjects: newSubjects ?? this.subjects,
|
||||
schoolHolidays: newHolidays ?? this.schoolHolidays,
|
||||
schoolyear: newSchoolyear ?? this.schoolyear,
|
||||
timegrid: newTimegrid ?? this.timegrid,
|
||||
customEvents: newCustomEvents ?? this.customEvents,
|
||||
dataVersion: dataVersion + 1,
|
||||
);
|
||||
}
|
||||
|
||||
bool get hasReferenceData =>
|
||||
rooms != null &&
|
||||
subjects != null &&
|
||||
|
||||
@@ -1,13 +1,12 @@
|
||||
import 'package:collection/collection.dart';
|
||||
|
||||
import '../../../../../api/marianumconnect/queries/timetable_get_week/timetable_get_week_response.dart';
|
||||
import '../../../../../extensions/date_time.dart';
|
||||
import '../../../../../utils/json_equality.dart';
|
||||
|
||||
/// Weeks kept around the viewed week and around today's week. Everything
|
||||
/// further away is dropped: every state emit re-serializes the whole cache for
|
||||
/// HydratedBloc and the calendar rebuilds its appointments from all of it, so
|
||||
/// an unbounded cache makes week swipes slower the longer the app is used.
|
||||
const int kWeekCacheRadius = 4;
|
||||
const int kWeekCacheRadius = 8;
|
||||
|
||||
/// Returns the cache with [week] stored under [weekStart], pruned to the
|
||||
/// weeks near [viewedWeekStart] or [now]. Returns null when the stored week
|
||||
@@ -21,10 +20,7 @@ Map<String, TimetableGetWeekResponse>? mergeWeekIntoCache(
|
||||
}) {
|
||||
final key = weekStart.weekKey();
|
||||
final existing = cache[key];
|
||||
if (existing != null &&
|
||||
const DeepCollectionEquality().equals(existing.toJson(), week.toJson())) {
|
||||
return null;
|
||||
}
|
||||
if (sameJson(existing, week)) return null;
|
||||
|
||||
final viewedMonday = viewedWeekStart.mondayOfWeek;
|
||||
final todayMonday = now.mondayOfWeek;
|
||||
|
||||
Reference in New Issue
Block a user