hardened API decoding against server fields the models did not expect
The Talk room list crashed for a new account because the server omits
lastMessage for rooms without a visible message and the model required it.
Beyond that single field, a review of the Talk models against the OpenAPI
spec of the installed version (23.0.8) found the same crash class in several
places: closed enums over open server values (inCall bitmask, rich-object
types, actor and message types), a deleted parent sent as {id, deleted},
and the autocomplete status arriving as an object.
- json_serializable `checked: true`: decode errors now name class and field
- lists (rooms, messages, participants, autocomplete) decode per entry;
a malformed entry is skipped and reported via ClientErrorReporter
- unknownEnumValue fallbacks for all response enums of Talk and breakers
- lastMessage nullable; inCall as bitmask; deleted parent placeholder;
autocomplete status object/string; fixed shareWithDisplayNameUnique key
- GetRoomParams no longer sends null query parameters
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HrepDTL4qDe35TuS29sLW3
This commit is contained in:
@@ -7,23 +7,49 @@ part of 'dev_tools_settings.dart';
|
||||
// **************************************************************************
|
||||
|
||||
DevToolsSettings _$DevToolsSettingsFromJson(Map<String, dynamic> json) =>
|
||||
DevToolsSettings(
|
||||
showPerformanceOverlay: json['showPerformanceOverlay'] as bool,
|
||||
showFrameStats: json['showFrameStats'] as bool? ?? false,
|
||||
showMemoryStats: json['showMemoryStats'] as bool? ?? false,
|
||||
showSemanticsDebugger: json['showSemanticsDebugger'] as bool? ?? false,
|
||||
slowAnimations: json['slowAnimations'] as bool? ?? false,
|
||||
textScaleOverride: (json['textScaleOverride'] as num?)?.toDouble() ?? 0,
|
||||
marianumConnectEndpoint:
|
||||
$enumDecodeNullable(
|
||||
_$MarianumConnectEndpointEnumMap,
|
||||
json['marianumConnectEndpoint'],
|
||||
) ??
|
||||
MarianumConnectEndpoint.live,
|
||||
marianumConnectCustomUrl:
|
||||
json['marianumConnectCustomUrl'] as String? ?? '',
|
||||
emergencyNoticeUrl: json['emergencyNoticeUrl'] as String? ?? '',
|
||||
);
|
||||
$checkedCreate('DevToolsSettings', json, ($checkedConvert) {
|
||||
final val = DevToolsSettings(
|
||||
showPerformanceOverlay: $checkedConvert(
|
||||
'showPerformanceOverlay',
|
||||
(v) => v as bool,
|
||||
),
|
||||
showFrameStats: $checkedConvert(
|
||||
'showFrameStats',
|
||||
(v) => v as bool? ?? false,
|
||||
),
|
||||
showMemoryStats: $checkedConvert(
|
||||
'showMemoryStats',
|
||||
(v) => v as bool? ?? false,
|
||||
),
|
||||
showSemanticsDebugger: $checkedConvert(
|
||||
'showSemanticsDebugger',
|
||||
(v) => v as bool? ?? false,
|
||||
),
|
||||
slowAnimations: $checkedConvert(
|
||||
'slowAnimations',
|
||||
(v) => v as bool? ?? false,
|
||||
),
|
||||
textScaleOverride: $checkedConvert(
|
||||
'textScaleOverride',
|
||||
(v) => (v as num?)?.toDouble() ?? 0,
|
||||
),
|
||||
marianumConnectEndpoint: $checkedConvert(
|
||||
'marianumConnectEndpoint',
|
||||
(v) =>
|
||||
$enumDecodeNullable(_$MarianumConnectEndpointEnumMap, v) ??
|
||||
MarianumConnectEndpoint.live,
|
||||
),
|
||||
marianumConnectCustomUrl: $checkedConvert(
|
||||
'marianumConnectCustomUrl',
|
||||
(v) => v as String? ?? '',
|
||||
),
|
||||
emergencyNoticeUrl: $checkedConvert(
|
||||
'emergencyNoticeUrl',
|
||||
(v) => v as String? ?? '',
|
||||
),
|
||||
);
|
||||
return val;
|
||||
});
|
||||
|
||||
Map<String, dynamic> _$DevToolsSettingsToJson(DevToolsSettings instance) =>
|
||||
<String, dynamic>{
|
||||
|
||||
Reference in New Issue
Block a user