hardened API decoding against server fields the models did not expect
The Talk room list crashed for a new account because the server omits
lastMessage for rooms without a visible message and the model required it.
Beyond that single field, a review of the Talk models against the OpenAPI
spec of the installed version (23.0.8) found the same crash class in several
places: closed enums over open server values (inCall bitmask, rich-object
types, actor and message types), a deleted parent sent as {id, deleted},
and the autocomplete status arriving as an object.
- json_serializable `checked: true`: decode errors now name class and field
- lists (rooms, messages, participants, autocomplete) decode per entry;
a malformed entry is skipped and reported via ClientErrorReporter
- unknownEnumValue fallbacks for all response enums of Talk and breakers
- lastMessage nullable; inCall as bitmask; deleted parent placeholder;
autocomplete status object/string; fixed shareWithDisplayNameUnique key
- GetRoomParams no longer sends null query parameters
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HrepDTL4qDe35TuS29sLW3
This commit is contained in:
@@ -187,16 +187,18 @@ class ChatListBloc
|
||||
/// Clears unread too — long-poll only feeds this in for an actively-open chat.
|
||||
void applyIncomingMessage(String token, GetChatResponseObject message) {
|
||||
_mutateRoom(token, (r) {
|
||||
final wasRead =
|
||||
r.unreadMessages == 0 && r.lastReadMessage >= message.id;
|
||||
final hasNewer = r.lastMessage.id >= message.id;
|
||||
final wasRead = r.unreadMessages == 0 && r.lastReadMessage >= message.id;
|
||||
final lastId = r.lastMessage?.id ?? 0;
|
||||
final hasNewer = lastId >= message.id;
|
||||
if (wasRead && hasNewer) return false;
|
||||
r.unreadMessages = 0;
|
||||
r.unreadMention = false;
|
||||
r.unreadMentionDirect = false;
|
||||
if (message.id > r.lastReadMessage) r.lastReadMessage = message.id;
|
||||
if (message.id > r.lastMessage.id) r.lastMessage = message;
|
||||
if (message.timestamp > r.lastActivity) r.lastActivity = message.timestamp;
|
||||
if (message.id > lastId) r.lastMessage = message;
|
||||
if (message.timestamp > r.lastActivity) {
|
||||
r.lastActivity = message.timestamp;
|
||||
}
|
||||
return true;
|
||||
});
|
||||
}
|
||||
|
||||
@@ -7,11 +7,17 @@ part of 'chat_list_state.dart';
|
||||
// **************************************************************************
|
||||
|
||||
_ChatListState _$ChatListStateFromJson(Map<String, dynamic> json) =>
|
||||
_ChatListState(
|
||||
rooms: json['rooms'] == null
|
||||
? null
|
||||
: GetRoomResponse.fromJson(json['rooms'] as Map<String, dynamic>),
|
||||
);
|
||||
$checkedCreate('_ChatListState', json, ($checkedConvert) {
|
||||
final val = _ChatListState(
|
||||
rooms: $checkedConvert(
|
||||
'rooms',
|
||||
(v) => v == null
|
||||
? null
|
||||
: GetRoomResponse.fromJson(v as Map<String, dynamic>),
|
||||
),
|
||||
);
|
||||
return val;
|
||||
});
|
||||
|
||||
Map<String, dynamic> _$ChatListStateToJson(_ChatListState instance) =>
|
||||
<String, dynamic>{'rooms': instance.rooms};
|
||||
|
||||
Reference in New Issue
Block a user