hardened API decoding against server fields the models did not expect
The Talk room list crashed for a new account because the server omits
lastMessage for rooms without a visible message and the model required it.
Beyond that single field, a review of the Talk models against the OpenAPI
spec of the installed version (23.0.8) found the same crash class in several
places: closed enums over open server values (inCall bitmask, rich-object
types, actor and message types), a deleted parent sent as {id, deleted},
and the autocomplete status arriving as an object.
- json_serializable `checked: true`: decode errors now name class and field
- lists (rooms, messages, participants, autocomplete) decode per entry;
a malformed entry is skipped and reported via ClientErrorReporter
- unknownEnumValue fallbacks for all response enums of Talk and breakers
- lastMessage nullable; inCall as bitmask; deleted parent placeholder;
autocomplete status object/string; fixed shareWithDisplayNameUnique key
- GetRoomParams no longer sends null query parameters
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HrepDTL4qDe35TuS29sLW3
This commit is contained in:
@@ -411,6 +411,7 @@ class ChatBloc
|
||||
case GetRoomResponseObjectMessageType.deletedComment:
|
||||
case GetRoomResponseObjectMessageType.system:
|
||||
case GetRoomResponseObjectMessageType.command:
|
||||
case GetRoomResponseObjectMessageType.unknown:
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -6,14 +6,30 @@ part of 'chat_state.dart';
|
||||
// JsonSerializableGenerator
|
||||
// **************************************************************************
|
||||
|
||||
_ChatState _$ChatStateFromJson(Map<String, dynamic> json) => _ChatState(
|
||||
currentToken: json['currentToken'] as String? ?? '',
|
||||
chatResponse: json['chatResponse'] == null
|
||||
? null
|
||||
: GetChatResponse.fromJson(json['chatResponse'] as Map<String, dynamic>),
|
||||
referenceMessageId: (json['referenceMessageId'] as num?)?.toInt(),
|
||||
hasMoreOld: json['hasMoreOld'] as bool? ?? true,
|
||||
isLoadingOlder: json['isLoadingOlder'] as bool? ?? false,
|
||||
_ChatState _$ChatStateFromJson(Map<String, dynamic> json) => $checkedCreate(
|
||||
'_ChatState',
|
||||
json,
|
||||
($checkedConvert) {
|
||||
final val = _ChatState(
|
||||
currentToken: $checkedConvert('currentToken', (v) => v as String? ?? ''),
|
||||
chatResponse: $checkedConvert(
|
||||
'chatResponse',
|
||||
(v) => v == null
|
||||
? null
|
||||
: GetChatResponse.fromJson(v as Map<String, dynamic>),
|
||||
),
|
||||
referenceMessageId: $checkedConvert(
|
||||
'referenceMessageId',
|
||||
(v) => (v as num?)?.toInt(),
|
||||
),
|
||||
hasMoreOld: $checkedConvert('hasMoreOld', (v) => v as bool? ?? true),
|
||||
isLoadingOlder: $checkedConvert(
|
||||
'isLoadingOlder',
|
||||
(v) => v as bool? ?? false,
|
||||
),
|
||||
);
|
||||
return val;
|
||||
},
|
||||
);
|
||||
|
||||
Map<String, dynamic> _$ChatStateToJson(_ChatState instance) =>
|
||||
|
||||
Reference in New Issue
Block a user