hardened API decoding against server fields the models did not expect
The Talk room list crashed for a new account because the server omits
lastMessage for rooms without a visible message and the model required it.
Beyond that single field, a review of the Talk models against the OpenAPI
spec of the installed version (23.0.8) found the same crash class in several
places: closed enums over open server values (inCall bitmask, rich-object
types, actor and message types), a deleted parent sent as {id, deleted},
and the autocomplete status arriving as an object.
- json_serializable `checked: true`: decode errors now name class and field
- lists (rooms, messages, participants, autocomplete) decode per entry;
a malformed entry is skipped and reported via ClientErrorReporter
- unknownEnumValue fallbacks for all response enums of Talk and breakers
- lastMessage nullable; inCall as bitmask; deleted parent placeholder;
autocomplete status object/string; fixed shareWithDisplayNameUnique key
- GetRoomParams no longer sends null query parameters
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HrepDTL4qDe35TuS29sLW3
This commit is contained in:
@@ -25,6 +25,7 @@ class GetBreakersResponse extends ApiResponse {
|
||||
|
||||
@JsonSerializable()
|
||||
class BreakerRule {
|
||||
@JsonKey(unknownEnumValue: BreakerArea.unknown)
|
||||
List<BreakerArea> areas;
|
||||
String message;
|
||||
|
||||
@@ -69,4 +70,7 @@ enum BreakerArea {
|
||||
feedback,
|
||||
@JsonValue('MORE')
|
||||
more,
|
||||
|
||||
/// An area the backend added after this build; no module maps to it.
|
||||
unknown,
|
||||
}
|
||||
|
||||
@@ -7,15 +7,25 @@ part of 'get_breakers_response.dart';
|
||||
// **************************************************************************
|
||||
|
||||
GetBreakersResponse _$GetBreakersResponseFromJson(Map<String, dynamic> json) =>
|
||||
GetBreakersResponse(
|
||||
(json['rules'] as List<dynamic>?)
|
||||
?.map((e) => BreakerRule.fromJson(e as Map<String, dynamic>))
|
||||
.toList() ??
|
||||
[],
|
||||
)
|
||||
..headers = (json['headers'] as Map<String, dynamic>?)?.map(
|
||||
(k, e) => MapEntry(k, e as String),
|
||||
$checkedCreate('GetBreakersResponse', json, ($checkedConvert) {
|
||||
final val = GetBreakersResponse(
|
||||
$checkedConvert(
|
||||
'rules',
|
||||
(v) =>
|
||||
(v as List<dynamic>?)
|
||||
?.map((e) => BreakerRule.fromJson(e as Map<String, dynamic>))
|
||||
.toList() ??
|
||||
[],
|
||||
),
|
||||
);
|
||||
$checkedConvert(
|
||||
'headers',
|
||||
(v) => val.headers = (v as Map<String, dynamic>?)?.map(
|
||||
(k, e) => MapEntry(k, e as String),
|
||||
),
|
||||
);
|
||||
return val;
|
||||
});
|
||||
|
||||
Map<String, dynamic> _$GetBreakersResponseToJson(
|
||||
GetBreakersResponse instance,
|
||||
@@ -24,13 +34,26 @@ Map<String, dynamic> _$GetBreakersResponseToJson(
|
||||
'rules': instance.rules.map((e) => e.toJson()).toList(),
|
||||
};
|
||||
|
||||
BreakerRule _$BreakerRuleFromJson(Map<String, dynamic> json) => BreakerRule(
|
||||
(json['areas'] as List<dynamic>)
|
||||
.map((e) => $enumDecode(_$BreakerAreaEnumMap, e))
|
||||
.toList(),
|
||||
json['message'] as String,
|
||||
(json['maxBuild'] as num?)?.toInt(),
|
||||
);
|
||||
BreakerRule _$BreakerRuleFromJson(Map<String, dynamic> json) =>
|
||||
$checkedCreate('BreakerRule', json, ($checkedConvert) {
|
||||
final val = BreakerRule(
|
||||
$checkedConvert(
|
||||
'areas',
|
||||
(v) => (v as List<dynamic>)
|
||||
.map(
|
||||
(e) => $enumDecode(
|
||||
_$BreakerAreaEnumMap,
|
||||
e,
|
||||
unknownValue: BreakerArea.unknown,
|
||||
),
|
||||
)
|
||||
.toList(),
|
||||
),
|
||||
$checkedConvert('message', (v) => v as String),
|
||||
$checkedConvert('maxBuild', (v) => (v as num?)?.toInt()),
|
||||
);
|
||||
return val;
|
||||
});
|
||||
|
||||
Map<String, dynamic> _$BreakerRuleToJson(BreakerRule instance) =>
|
||||
<String, dynamic>{
|
||||
@@ -52,4 +75,5 @@ const _$BreakerAreaEnumMap = {
|
||||
BreakerArea.dates: 'DATES',
|
||||
BreakerArea.feedback: 'FEEDBACK',
|
||||
BreakerArea.more: 'MORE',
|
||||
BreakerArea.unknown: 'unknown',
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user