hardened API decoding against server fields the models did not expect
The Talk room list crashed for a new account because the server omits
lastMessage for rooms without a visible message and the model required it.
Beyond that single field, a review of the Talk models against the OpenAPI
spec of the installed version (23.0.8) found the same crash class in several
places: closed enums over open server values (inCall bitmask, rich-object
types, actor and message types), a deleted parent sent as {id, deleted},
and the autocomplete status arriving as an object.
- json_serializable `checked: true`: decode errors now name class and field
- lists (rooms, messages, participants, autocomplete) decode per entry;
a malformed entry is skipped and reported via ClientErrorReporter
- unknownEnumValue fallbacks for all response enums of Talk and breakers
- lastMessage nullable; inCall as bitmask; deleted parent placeholder;
autocomplete status object/string; fixed shareWithDisplayNameUnique key
- GetRoomParams no longer sends null query parameters
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HrepDTL4qDe35TuS29sLW3
This commit is contained in:
@@ -7,16 +7,18 @@ part of 'get_room_response.dart';
|
||||
// **************************************************************************
|
||||
|
||||
GetRoomResponse _$GetRoomResponseFromJson(Map<String, dynamic> json) =>
|
||||
GetRoomResponse(
|
||||
(json['data'] as List<dynamic>)
|
||||
.map(
|
||||
(e) => GetRoomResponseObject.fromJson(e as Map<String, dynamic>),
|
||||
)
|
||||
.toSet(),
|
||||
)
|
||||
..headers = (json['headers'] as Map<String, dynamic>?)?.map(
|
||||
(k, e) => MapEntry(k, e as String),
|
||||
$checkedCreate('GetRoomResponse', json, ($checkedConvert) {
|
||||
final val = GetRoomResponse(
|
||||
$checkedConvert('data', (v) => _roomsFromJson(v)),
|
||||
);
|
||||
$checkedConvert(
|
||||
'headers',
|
||||
(v) => val.headers = (v as Map<String, dynamic>?)?.map(
|
||||
(k, e) => MapEntry(k, e as String),
|
||||
),
|
||||
);
|
||||
return val;
|
||||
});
|
||||
|
||||
Map<String, dynamic> _$GetRoomResponseToJson(GetRoomResponse instance) =>
|
||||
<String, dynamic>{
|
||||
@@ -26,41 +28,61 @@ Map<String, dynamic> _$GetRoomResponseToJson(GetRoomResponse instance) =>
|
||||
|
||||
GetRoomResponseObject _$GetRoomResponseObjectFromJson(
|
||||
Map<String, dynamic> json,
|
||||
) => GetRoomResponseObject(
|
||||
(json['id'] as num).toInt(),
|
||||
json['token'] as String,
|
||||
$enumDecode(_$GetRoomResponseObjectConversationTypeEnumMap, json['type']),
|
||||
json['name'] as String,
|
||||
json['displayName'] as String,
|
||||
json['description'] as String,
|
||||
(json['participantType'] as num).toInt(),
|
||||
(json['participantFlags'] as num).toInt(),
|
||||
(json['readOnly'] as num).toInt(),
|
||||
(json['listable'] as num).toInt(),
|
||||
(json['lastPing'] as num).toInt(),
|
||||
json['sessionId'] as String,
|
||||
json['hasPassword'] as bool,
|
||||
json['hasCall'] as bool,
|
||||
(json['callFlag'] as num).toInt(),
|
||||
json['canStartCall'] as bool,
|
||||
json['canDeleteConversation'] as bool,
|
||||
json['canLeaveConversation'] as bool,
|
||||
(json['lastActivity'] as num).toInt(),
|
||||
json['isFavorite'] as bool,
|
||||
$enumDecode(
|
||||
_$GetRoomResponseObjectParticipantNotificationLevelEnumMap,
|
||||
json['notificationLevel'],
|
||||
),
|
||||
(json['unreadMessages'] as num).toInt(),
|
||||
json['unreadMention'] as bool,
|
||||
json['unreadMentionDirect'] as bool,
|
||||
(json['lastReadMessage'] as num).toInt(),
|
||||
(json['lastCommonReadMessage'] as num).toInt(),
|
||||
GetChatResponseObject.fromJson(json['lastMessage'] as Map<String, dynamic>),
|
||||
json['status'] as String?,
|
||||
json['statusIcon'] as String?,
|
||||
json['statusMessage'] as String?,
|
||||
);
|
||||
) => $checkedCreate('GetRoomResponseObject', json, ($checkedConvert) {
|
||||
final val = GetRoomResponseObject(
|
||||
$checkedConvert('id', (v) => (v as num).toInt()),
|
||||
$checkedConvert('token', (v) => v as String),
|
||||
$checkedConvert(
|
||||
'type',
|
||||
(v) => $enumDecode(
|
||||
_$GetRoomResponseObjectConversationTypeEnumMap,
|
||||
v,
|
||||
unknownValue: GetRoomResponseObjectConversationType.unknown,
|
||||
),
|
||||
),
|
||||
$checkedConvert('name', (v) => v as String),
|
||||
$checkedConvert('displayName', (v) => v as String),
|
||||
$checkedConvert('description', (v) => v as String),
|
||||
$checkedConvert('participantType', (v) => (v as num).toInt()),
|
||||
$checkedConvert('participantFlags', (v) => (v as num).toInt()),
|
||||
$checkedConvert('readOnly', (v) => (v as num).toInt()),
|
||||
$checkedConvert('listable', (v) => (v as num).toInt()),
|
||||
$checkedConvert('lastPing', (v) => (v as num).toInt()),
|
||||
$checkedConvert('sessionId', (v) => v as String),
|
||||
$checkedConvert('hasPassword', (v) => v as bool),
|
||||
$checkedConvert('hasCall', (v) => v as bool),
|
||||
$checkedConvert('callFlag', (v) => (v as num).toInt()),
|
||||
$checkedConvert('canStartCall', (v) => v as bool),
|
||||
$checkedConvert('canDeleteConversation', (v) => v as bool),
|
||||
$checkedConvert('canLeaveConversation', (v) => v as bool),
|
||||
$checkedConvert('lastActivity', (v) => (v as num).toInt()),
|
||||
$checkedConvert('isFavorite', (v) => v as bool),
|
||||
$checkedConvert(
|
||||
'notificationLevel',
|
||||
(v) => $enumDecode(
|
||||
_$GetRoomResponseObjectParticipantNotificationLevelEnumMap,
|
||||
v,
|
||||
unknownValue:
|
||||
GetRoomResponseObjectParticipantNotificationLevel.defaultLevel,
|
||||
),
|
||||
),
|
||||
$checkedConvert('unreadMessages', (v) => (v as num).toInt()),
|
||||
$checkedConvert('unreadMention', (v) => v as bool),
|
||||
$checkedConvert('unreadMentionDirect', (v) => v as bool),
|
||||
$checkedConvert('lastReadMessage', (v) => (v as num).toInt()),
|
||||
$checkedConvert('lastCommonReadMessage', (v) => (v as num).toInt()),
|
||||
$checkedConvert(
|
||||
'lastMessage',
|
||||
(v) => v == null
|
||||
? null
|
||||
: GetChatResponseObject.fromJson(v as Map<String, dynamic>),
|
||||
),
|
||||
$checkedConvert('status', (v) => v as String?),
|
||||
$checkedConvert('statusIcon', (v) => v as String?),
|
||||
$checkedConvert('statusMessage', (v) => v as String?),
|
||||
);
|
||||
return val;
|
||||
});
|
||||
|
||||
Map<String, dynamic> _$GetRoomResponseObjectToJson(
|
||||
GetRoomResponseObject instance,
|
||||
@@ -93,7 +115,7 @@ Map<String, dynamic> _$GetRoomResponseObjectToJson(
|
||||
'unreadMentionDirect': instance.unreadMentionDirect,
|
||||
'lastReadMessage': instance.lastReadMessage,
|
||||
'lastCommonReadMessage': instance.lastCommonReadMessage,
|
||||
'lastMessage': instance.lastMessage.toJson(),
|
||||
'lastMessage': instance.lastMessage?.toJson(),
|
||||
'status': instance.status,
|
||||
'statusIcon': instance.statusIcon,
|
||||
'statusMessage': instance.statusMessage,
|
||||
@@ -106,6 +128,7 @@ const _$GetRoomResponseObjectConversationTypeEnumMap = {
|
||||
GetRoomResponseObjectConversationType.changelog: 4,
|
||||
GetRoomResponseObjectConversationType.deleted: 5,
|
||||
GetRoomResponseObjectConversationType.noteToSelf: 6,
|
||||
GetRoomResponseObjectConversationType.unknown: 'unknown',
|
||||
};
|
||||
|
||||
const _$GetRoomResponseObjectParticipantNotificationLevelEnumMap = {
|
||||
|
||||
Reference in New Issue
Block a user