From 03ee87d7cfb915a1182b74ecc244f79b18d28def Mon Sep 17 00:00:00 2001
From: bytedream <me@bytedream.dev>
Date: Mon, 23 Jun 2025 20:02:46 +0200
Subject: [PATCH] fix bit badge value not updating

---
 src/components/input/BitBadge.svelte | 31 ++++++++++++++--------------
 src/pages/admin/teams.astro          |  2 +-
 src/pages/admin/users/blocked.astro  |  2 +-
 src/pages/admin/users/index.astro    |  2 +-
 4 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/src/components/input/BitBadge.svelte b/src/components/input/BitBadge.svelte
index 0c7abb6..4bafc7a 100644
--- a/src/components/input/BitBadge.svelte
+++ b/src/components/input/BitBadge.svelte
@@ -9,20 +9,17 @@
   // inputs
   let { available, value = $bindable(), readonly }: Props = $props();
 
-  // idk why, but this is needed to trigger loop reactivity
-  let reactiveValue = $derived(value);
-
   // callbacks
   function onOptionSelect(e: Event) {
     const selected = Number((e.target as HTMLSelectElement).value);
 
-    reactiveValue |= selected;
+    value |= selected;
 
     (e.target as HTMLSelectElement).value = '-';
   }
 
   function onBadgeRemove(flag: number) {
-    reactiveValue &= ~flag;
+    value &= ~flag;
   }
 </script>
 
@@ -31,20 +28,22 @@
     <select class="select select-xs w-min" onchange={onOptionSelect}>
       <option selected hidden>-</option>
       {#each Object.entries(available) as [flag, badge] (flag)}
-        <option value={flag} hidden={(reactiveValue & Number(flag)) !== 0}>{badge}</option>
+        <option value={flag} hidden={(value & Number(flag)) !== 0}>{badge}</option>
       {/each}
     </select>
   {/if}
   <div class="flex flow flex-wrap gap-2">
-    {#each Object.entries(available) as [flag, badge] (flag)}
-      {#if (reactiveValue & Number(flag)) !== 0}
-        <div class="badge badge-outline gap-1">
-          {#if !readonly}
-            <button class="cursor-pointer" type="button" onclick={() => onBadgeRemove(Number(flag))}>✕</button>
-          {/if}
-          <span>{badge}</span>
-        </div>
-      {/if}
-    {/each}
+    {#key value}
+      {#each Object.entries(available) as [flag, badge] (flag)}
+        {#if (value & Number(flag)) !== 0}
+          <div class="badge badge-outline gap-1">
+            {#if !readonly}
+              <button class="cursor-pointer" type="button" onclick={() => onBadgeRemove(Number(flag))}>✕</button>
+            {/if}
+            <span>{badge}</span>
+          </div>
+        {/if}
+      {/each}
+    {/key}
   </div>
 </div>
diff --git a/src/pages/admin/teams.astro b/src/pages/admin/teams.astro
index 226067f..4e917fc 100644
--- a/src/pages/admin/teams.astro
+++ b/src/pages/admin/teams.astro
@@ -6,7 +6,7 @@ import { Session } from '@util/session.ts';
 import { Permissions } from '@util/permissions.ts';
 import { BASE_PATH } from 'astro:env/server';
 
-const session = Session.sessionFromCookies(Astro.cookies, Permissions.Admin);
+const session = Session.sessionFromCookies(Astro.cookies, Permissions.Users);
 if (!session) return Astro.redirect(`${BASE_PATH}/admin`);
 ---
 
diff --git a/src/pages/admin/users/blocked.astro b/src/pages/admin/users/blocked.astro
index b9ad919..cb69520 100644
--- a/src/pages/admin/users/blocked.astro
+++ b/src/pages/admin/users/blocked.astro
@@ -6,7 +6,7 @@ import { Session } from '@util/session.ts';
 import { Permissions } from '@util/permissions.ts';
 import { BASE_PATH } from 'astro:env/server';
 
-const session = Session.sessionFromCookies(Astro.cookies, Permissions.Admin);
+const session = Session.sessionFromCookies(Astro.cookies, Permissions.Users);
 if (!session) return Astro.redirect(`${BASE_PATH}/admin`);
 ---
 
diff --git a/src/pages/admin/users/index.astro b/src/pages/admin/users/index.astro
index 5d3cbdd..a49b911 100644
--- a/src/pages/admin/users/index.astro
+++ b/src/pages/admin/users/index.astro
@@ -6,7 +6,7 @@ import { Session } from '@util/session.ts';
 import { Permissions } from '@util/permissions.ts';
 import { BASE_PATH } from 'astro:env/server';
 
-const session = Session.sessionFromCookies(Astro.cookies, Permissions.Admin);
+const session = Session.sessionFromCookies(Astro.cookies, Permissions.Users);
 if (!session) return Astro.redirect(`${BASE_PATH}/admin`);
 ---