CraftAttack/spawn
6
0 Fork 0
Code Issues 5 Pull Requests Packages Projects Releases Wiki Activity

added New Year Firework #15

Merged
MineTec merged 4 commits from feature/NewYearFirework into master 2026-10-13 21:58:04 +00:00
Conversation 3 Commits 4 Files Changed 3
+8 -5
3 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 252758797d - Show all commits

No files matched your search

craftattack/src/main/java/eu/mhsl/craftattack/spawn/craftattack/appliances/gameplay/newYearFirework/NewYearFirework.java
+5
View File
@@ -11,6 +11,7 @@ import org.bukkit.inventory.meta.FireworkMeta;
import org.bukkit.persistence.PersistentDataType;
import org.jetbrains.annotations.NotNull;
import java.time.LocalDate;
import java.util.List;
import java.util.Locale;
@@ -36,6 +37,10 @@ public class NewYearFirework extends Appliance {
}
}
public boolean shouldSpawnFirework() {
return LocalDate.now().getDayOfYear() == 1;
}
@Override
protected @NotNull List<Listener> listeners() {
return List.of(new NewYearFireworkListener());
craftattack/src/main/java/eu/mhsl/craftattack/spawn/craftattack/appliances/gameplay/newYearFirework/NewYearFireworkListener.java
+2 -4
View File
@@ -6,12 +6,10 @@ import org.bukkit.event.EventHandler;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import java.time.LocalDate;
public class NewYearFireworkListener extends ApplianceListener<NewYearFirework> {
class NewYearFireworkListener extends ApplianceListener<NewYearFirework> {
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event) {
MineTec marked this conversation as resolved
MineTec commented 2026-10-13 20:21:10 +00:00
Review
Copy link
Copy source

package private

package private
if(LocalDate.now().getDayOfYear() != 1) return;
if(!this.getAppliance().shouldSpawnFirework()) return;
this.getAppliance().spawnFirework(event.getPlayer());
}
MineTec marked this conversation as resolved
MineTec commented 2026-10-13 20:24:29 +00:00
Review
Copy link
Copy source

der Check, ob heute Neujahr ist, gilt als Logik, und sollte daher in die Appliance ausgelagert werden. Einfach eine Methode, die true zurück gibt, wenn Feuerwerk kommen soll. Und hier dann einfach (!Appliance#shouldSpawnFirework) return

der Check, ob heute Neujahr ist, gilt als Logik, und sollte daher in die Appliance ausgelagert werden. Einfach eine Methode, die `true` zurück gibt, wenn Feuerwerk kommen soll. Und hier dann einfach `(!Appliance#shouldSpawnFirework) return`
@EventHandler
craftattack/src/main/java/eu/mhsl/craftattack/spawn/craftattack/appliances/gameplay/quarzRecipe/QuarzRecipeListener.java
+1 -1
View File
@@ -4,7 +4,7 @@ import eu.mhsl.craftattack.spawn.core.appliance.ApplianceListener;
import org.bukkit.event.EventHandler;
import org.bukkit.event.player.PlayerJoinEvent;
public class QuarzRecipeListener extends ApplianceListener<QuarzRecipe> {
class QuarzRecipeListener extends ApplianceListener<QuarzRecipe> {
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event) {
this.getAppliance().unlock(event.getPlayer());