added New Year Firework #15

2026-10-12T14:22:09Z

jannis commented

2026-10-12 14:22:09 +00:00

No description provided.

jannis added 1 commit 2026-10-12 14:22:10 +00:00

added New Year Firework 62a42e561e

MineTec added 1 commit 2026-10-13 20:20:53 +00:00

Merge branch 'master' into feature/NewYearFirework 1b79e35bd2

MineTec reviewed

2026-10-13 20:21:10 +00:00

craftattack/src/main/java/eu/mhsl/craftattack/spawn/craftattack/appliances/gameplay/newYearFirework/NewYearFireworkListener.java

						
				@@ -0,0 +8,4 @@

				import java.time.LocalDate;

				public class NewYearFireworkListener extends ApplianceListener<NewYearFirework> {

MineTec commented

2026-10-13 20:21:10 +00:00

package private

MineTec marked this conversation as resolved

MineTec reviewed

2026-10-13 20:24:29 +00:00

craftattack/src/main/java/eu/mhsl/craftattack/spawn/craftattack/appliances/gameplay/newYearFirework/NewYearFireworkListener.java

						
				@@ -0,0 +11,4 @@

				public class NewYearFireworkListener extends ApplianceListener<NewYearFirework> {

				    @EventHandler

				    public void onPlayerJoin(PlayerJoinEvent event) {

				        if(LocalDate.now().getDayOfYear() != 1) return;

MineTec commented

2026-10-13 20:24:29 +00:00

der Check, ob heute Neujahr ist, gilt als Logik, und sollte daher in die Appliance ausgelagert werden. Einfach eine Methode, die true zurück gibt, wenn Feuerwerk kommen soll. Und hier dann einfach (!Appliance#shouldSpawnFirework) return

der Check, ob heute Neujahr ist, gilt als Logik, und sollte daher in die Appliance ausgelagert werden. Einfach eine Methode, die `true` zurück gibt, wenn Feuerwerk kommen soll. Und hier dann einfach `(!Appliance#shouldSpawnFirework) return`

MineTec marked this conversation as resolved

jannis added 1 commit 2026-10-13 20:52:47 +00:00

fixed issues in NewYearFirework and QuarzRecipe 252758797d

MineTec added 1 commit 2026-10-13 21:57:53 +00:00

Merge branch 'master' into feature/NewYearFirework 2c8c4fbf87

MineTec commented

2026-10-13 21:57:59 +00:00

passt.

MineTec merged commit 9dbee7d63b into master

2026-10-13 21:58:04 +00:00

MineTec deleted branch feature/NewYearFirework

2026-10-13 21:58:04 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: CraftAttack/spawn#15