From 9004609c1b16785ef9149ef1ddc8c3e2eeda3b9f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Elias=20M=C3=BCller?= Date: Sun, 8 Dec 2024 22:36:11 +0100 Subject: [PATCH] better synchronous call warning --- .../craftattack/spawn/api/client/HttpRepository.java | 2 +- .../mhsl/craftattack/spawn/api/client/Repository.java | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/main/java/eu/mhsl/craftattack/spawn/api/client/HttpRepository.java b/src/main/java/eu/mhsl/craftattack/spawn/api/client/HttpRepository.java index 0f66ef4..b218771 100644 --- a/src/main/java/eu/mhsl/craftattack/spawn/api/client/HttpRepository.java +++ b/src/main/java/eu/mhsl/craftattack/spawn/api/client/HttpRepository.java @@ -74,7 +74,7 @@ public abstract class HttpRepository extends Repository { private ReqResp sendHttp(HttpRequest request) { try(HttpClient client = HttpClient.newHttpClient()) { - this.validateThread(); + this.validateThread(request.uri().getPath()); HttpResponse httpResponse = client.send(request, HttpResponse.BodyHandlers.ofString()); return new ReqResp<>(httpResponse.statusCode(), httpResponse.body()); } catch(IOException | InterruptedException e) { diff --git a/src/main/java/eu/mhsl/craftattack/spawn/api/client/Repository.java b/src/main/java/eu/mhsl/craftattack/spawn/api/client/Repository.java index d51a943..17ea323 100644 --- a/src/main/java/eu/mhsl/craftattack/spawn/api/client/Repository.java +++ b/src/main/java/eu/mhsl/craftattack/spawn/api/client/Repository.java @@ -15,7 +15,13 @@ public abstract class Repository { this.gson = new Gson(); } - protected void validateThread() { - if(Bukkit.isPrimaryThread()) Main.logger().warning("Repository was called synchronously!"); + protected void validateThread(String commandName) { + if(!Bukkit.isPrimaryThread()) return; + + Main.logger().warning(String.format( + "Repository '%s' was called synchronously with command '%s'!", + this.getClass().getSimpleName(), + commandName + )); } }